Clean up old TxParameters SQL table #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
reviewed
Jun 10, 2020
| -- | This table became @protocol_parameters@. | ||
| removeOldTxParametersTable :: Sqlite.Connection -> IO () | ||
| removeOldTxParametersTable conn = do | ||
| dropTable <- Sqlite.prepare conn "DROP TABLE IF EXISTS tx_parameters;" |
There was a problem hiding this comment.
Could be nice to first look for the table using isFieldPresent and then, log accordingly depending on the outcome?
KtorZ
approved these changes
Jun 10, 2020
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 12, 2020
1735: Clean up old TxParameters SQL table r=KtorZ a=rvl ### Issue Number Closes #1727 ### Overview Remove an old SQL table, if it exists. Co-authored-by: Rodney Lorrimar <[email protected]>
Build failed |
KtorZ
force-pushed
the
rvl/1727/cleanup-sqlite-table
branch
from
2fa5f70 to
20ef4ff
Compare
|
bors r+ |
|
From the buildkite log it looks like the integration tests may have a fd leak. |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 12, 2020
1735: Clean up old TxParameters SQL table r=KtorZ a=rvl ### Issue Number Closes #1727 ### Overview Remove an old SQL table, if it exists. Co-authored-by: Rodney Lorrimar <[email protected]>
KtorZ
added
the
IMPROVEMENT
|
@rvl Yes, I've observed this a few times already and I am trying to pinpoint the issue without success. Sometimes, there's something causing an internal error on the server, after what, workers stop being removed and simply pile up as the test move forward. Listing wallets returns a bazillion number of wallets while also causing all subsequent test to fail. The cause is unclear. |
Build failed |
rvl
force-pushed
the
rvl/1727/cleanup-sqlite-table
branch
from
b33273e to
b263454
Compare
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Closes #1727
Overview
Remove an old SQL table, if it exists.