Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scenario to illustrate the migration 500 error on Jormungandr #1682

Merged
merged 1 commit into from
May 22, 2020

Conversation

piotr-iohk
Copy link
Contributor

Issue Number

#1658

Overview

  • 22ddb84
    Scenario to illustrate the migration 500 error on Jormungandr

Comments

This is regarding #1658 (comment).

In the test I am using byron mainnet and byron testnet address and currently the response from the server is 500 (with Jormungandr), and that is what I left in the test for the time being. I think that it should be probably something more user firendly...

@piotr-iohk piotr-iohk requested review from rvl and paweljakubas May 22, 2020 11:42
@piotr-iohk piotr-iohk self-assigned this May 22, 2020
, addresses: [#{addr}]
}|])
verify r
[ expectResponseCode @IO HTTP.status500
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we expect HTTP.status400 and set the test to pending?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, corrected.

@piotr-iohk
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 22, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants