Testing Support bech32 encoding

[piotr-iohk]

Issue Number

#1603

Overview

• 00306f0
  Polish key CLI help

• 285add3
  Additional integration test for inspecting bech32 result

Comments

Before:

$ cardano-wallet-jormungandr key root
Usage: cardano-wallet-jormungandr key root [--wallet-style WALLET_STYLE]
                                           MNEMONIC_WORD...
                                           [--encoding KEY-ENCODING]
  Extract root extended private key from a mnemonic sentence.

Available options:
  -h,--help                Show this help text
  --wallet-style WALLET_STYLE
                           Any of the following (default: icarus)
                             icarus (15 mnemonic words)
                             trezor (12, 15, 18, 21 or 24 mnemonic words)
                             ledger (12, 15, 18, 21 or 24 mnemonic words)

After:

$ cardano-wallet-jormungandr key root
Usage: cardano-wallet-jormungandr key root [--wallet-style WALLET_STYLE]
                                           [--encoding KEY-ENCODING]
                                           MNEMONIC_WORD...
  Extract root extended private key from a mnemonic sentence.

Available options:
  -h,--help                Show this help text
  --wallet-style WALLET_STYLE
                           Any of the following (default: icarus)
                             icarus (15 mnemonic words)
                             trezor (12, 15, 18, 21 or 24 mnemonic words)
                             ledger (12, 15, 18, 21 or 24 mnemonic words)
  --encoding KEY-ENCODING  Either 'hex' or 'bech32' (default: hex)

Also updated:

• https://github.com/input-output-hk/cardano-wallet/wiki/Wallet-command-line-interface#key-root
• https://github.com/input-output-hk/cardano-wallet/wiki/Wallet-Command-Line-Interface-(cardano-wallet-byron)#key-root

[KtorZ]

This just makes me realize: the mnemonic words should also probably be read from stdin instead of passed as argument!

[KtorZ]

bors r+

[iohk-bors]

Build failed

• ci/hydra:Cardano:cardano-wallet:required

[piotr-iohk]

hydra failed:

Failures:

  test/integration/Test/Integration/Byron/Scenario/API/Addresses.hs:278:11: 
  1) API Specifications, BYRON_ADDRESSES, ADDRESS_CREATE_06 - Cannot create an address that already exists
       expected: Status {statusCode = 409, statusMessage = "Conflict"}
        but got: Status {statusCode = 201, statusMessage = "Created"}
       
       from the following response: Right (ApiAddress {id = (ApiT {getApiT = Address {unAddress = "\130\216\CANXB\131X\FS\250\EOTR\224\219\&7W|\ENQ\189\191y\130+\193\129\246\196\vXEd\SIr\135\172c|\161\SOHX\RSX\FSa.\142\214q\181\149=\DC44i\139#`\CAN>g\CAN\204\176\218\255I[F\131$\149\NUL\SUBZ\174\235\135"}},Proxy), state = ApiT {getApiT = Unused}})

  To rerun use: --match "/API Specifications/BYRON_ADDRESSES/ADDRESS_CREATE_06 - Cannot create an address that already exists/"

  test/integration/Test/Integration/Byron/Scenario/CLI/Addresses.hs:310:5: 
  2) CLI Specifications, BYRON_CLI_ADDRESSES, CLI_ADDRESS_CREATE_06 - Cannot create an address that already exists
       "Please enter your passphrase: *****************\nOk.\n" does not contain "I already know of such address."

Another occurence of -> #1644

[piotr-iohk]

bors r+

[iohk-bors]

Build failed

• ci/hydra:Cardano:cardano-wallet:required

[KtorZ]

@piotr-iohk this is going to be "annoying". Hydra caches the build result, so it won't re-run the test suite to retry the flaky test.
One way to work around this could be to rewrite the head git commit --amend -C HEAD, and re-push it so that it has a different commit hash.

[piotr-iohk]

Btw. I don't think the test that is flaky, I was able to reproduce the problem manually today -> #1644 (comment).

[piotr-iohk]

bors r+

[iohk-bors]

Build failed

• ci/hydra:Cardano:cardano-wallet:required