NetworkLayer.listen: don't "die" when node backend fails #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"die" will exit the process, which might not be what we want in all cases. Throw an exception instead, which will also result in the process exiting, but could be caught if needed.
|
🎉 Yeay! |
|
In the long-run, I wonder if we should just handle some of those with a log message, perhaps with a small re-connection delay of something like this. This could also just be done by an external service supervising our application in production; following a bit Erlang strategy: crash early. |
KtorZ
approved these changes
Apr 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of investigations into #100.
Overview
"die" will exit the process, which might not be what we want in all cases. Throw an exception instead, which will also result in the process exiting, but could be caught if needed.