-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port the Request module from the integration framework minus the typed client (only allow arbitrary raw JSON requests) #56
Comments
This provides `unsafeRequest`. A little bit of the DSL module was ported so that I could test the function. Relates to #56
This provides `unsafeRequest`. A little bit of the DSL module was ported so that I could test the function. Relates to #56
lgtm 👍 I have added also response code verification in #104.
|
@piotr-iohk Are you intending to the development for the points you mentioned as part of this ticket? (in which case, I'd suggest to put it back to 'In Progress'), or can close this one and tackle the remaining points as debts next week ? |
@KtorZ - yes, the latter 👍 i.e.:
|
Context
Since we are starting to shape API for the wallet we want a way to have it tested using integration tests.
This task is about porting the Request module from the cardano-wallet-legacy into new wallet.
For the new wallet's integration tests we want to use only the
unsafeRequest
approach and give up on usingtyped-client
approach as the first one turned out to be more versatile in terms of producing both positive and negative test scenarios in the past.Decision
Port all the functions from Request into new wallet that are necessary to submit raw JSON request (
unsafeRequest
) and get raw response from the request. The response needs to contain response body and response code such that it can be than asserted using test framework's DSL (#55).Do not port anything related with the typed-client approach.
Acceptance Criteria
unsafeRequest
approach)Development Plan
unsafeRequest
and removeservant-client
specific code.unsafeRequest
works.unsafeRequest
justrequest
because we don't have typed requests.PR
master
master
QA
The initial test should be run with:
This can be considered to be working if the
request
function can be used for new test scenarios.The text was updated successfully, but these errors were encountered: