Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

500 "Something went wrong" when listing transactions on wallet with old metadata #2172

Closed
piotr-iohk opened this issue Sep 23, 2020 · 3 comments
Assignees
Labels
Bug SEVERITY:HIGH A core functionality of the system isn't unresponsive or returning invalid data.

Comments

@piotr-iohk
Copy link
Contributor

Context

Information -
Version 2020.9.22 (git revision: 0c9ce882bb1663e11af9e08d7f763834636e5344)
Platform All
Installation from release

Steps to Reproduce

  1. Have a wallet with transactions with metadata created in 2020-09-11 wallet version
  2. Update to wallet 2020-09-22
  3. List transactions for the wallet

Expected behavior

All transactions are listed.

Actual behavior

Api returns:

"Something went wrong"

In the log there is:

 [GET] /v2/wallets/e36fe2c96998cfab9581b226af0ace8b6a730aae/transactions
PersistMarshalError "Couldn't parse field `txMetaData` from table `tx_meta`. JSON schema error within the metadata item 0: \"cardano\"\nJSON object expected. Unexpected value: \"cardano\""

Resolution


QA

@piotr-iohk piotr-iohk added Bug SEVERITY:HIGH A core functionality of the system isn't unresponsive or returning invalid data. labels Sep 23, 2020
@rvl
Copy link
Contributor

rvl commented Sep 23, 2020

This is highly annoying, but thanks for raising the issue.

I feel inclined to solve this by adding a release note saying that if you are one of the tiny number of people who used v2020-09-11 to send or receive transactions with metadata, then you should delete your wallet database and restore from genesis.

@KtorZ
Copy link
Member

KtorZ commented Sep 24, 2020

@rvl it should be possible to fallback on the old parsing method when de-serializing from the database, at least temporarily. Then, it'll be replace with the right format when re-inserted.

@piotr-iohk
Copy link
Contributor Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug SEVERITY:HIGH A core functionality of the system isn't unresponsive or returning invalid data.
Projects
None yet
Development

No branches or pull requests

3 participants