Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Margin, cost & pledge for pools #1719

Closed
Anviking opened this issue Jun 3, 2020 · 3 comments
Closed

Margin, cost & pledge for pools #1719

Anviking opened this issue Jun 3, 2020 · 3 comments
Assignees
@Anviking @KtorZ
Milestone
(ADP-311) List st...

Comments

@Anviking
Copy link
Member

Anviking commented Jun 3, 2020 •
edited by KtorZ
Loading

Context

We want to implement this endpoint for (the cardano-node-) Shelley.
https://input-output-hk.github.io/cardano-wallet/api/edge/#operation/listStakePools

Pool margin and cost cannot be retrieved through the node's local state query.

Decision

It seems we have to traverse the chain for pool registration certificates, to get this data?

Acceptance Criteria

  • Stake pool margin must be available in API (and CLI)
  • Stake pool cost must be available in API (and CLI)
  • Stake pool pledge must be available in API (and CLI)

Development

QA
@Anviking Anviking added this to the (ADP-311) List stake pools milestone Jun 3, 2020
@Anviking Anviking self-assigned this Jun 3, 2020
@Anviking
Copy link
Member Author

Superseded by #1761

@Anviking Anviking mentioned this issue Jun 16, 2020
Merged
7 tasks
@Anviking Anviking reopened this Jun 16, 2020
@Anviking
Copy link
Member Author

That ticket seems more about the writing of it, so re-opening this for the reading-aspect.

iohk-bors bot added a commit that referenced this issue Jun 23, 2020
@iohk-bors @Anviking @KtorZ
Merge #1769
4dc50fc 
1769: Use and combine chain data with LSQ data for stake pools r=KtorZ a=Anviking

# Issue Number

ADP-311, #1719 

# Overview

- [x] Add Shelley `MsgFetchedNodePoolLsqData` trace
- [x] Use and combine chain data with LSQ when listing pools
- [x] Update swagger to make pool cost and margin nullable
- [x] Make API types nullable
- [x] Add model implementation for `readPoolMetadata`


# Comments

- [ ] We should test that we order by non-myopic rewards, but that would require the pools producing blocks. 
- [ ] Maybe we should have a DB test checking that `readMetadata` returns what we previously put in the DB.

<!-- Additional comments or screenshots to attach if any -->

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Assign the PR to a corresponding milestone
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: Johannes Lund <[email protected]>
Co-authored-by: KtorZ <[email protected]>
@KtorZ KtorZ changed the title Margin and cost for pools Margin, cost & pledge for pools Jun 25, 2020
@KtorZ KtorZ self-assigned this Jun 25, 2020
@KtorZ KtorZ mentioned this issue Jun 25, 2020
Merged
iohk-bors bot added a commit that referenced this issue Jun 26, 2020
@iohk-bors @KtorZ
Merge #1800
90e275f 
1800: wire pool's 'pledge' from the registration certificate unto the Api r=KtorZ a=KtorZ

# Issue Number

<!-- Put here a reference to the issue this PR relates to and which requirements it tackles -->

#1719

# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- 027ce66
  📍 **wire pool's 'pledge' from the registration certificate unto the Api**
  
- 37384c6
  📍 **fix typo in swagger documentation 'ommitted' -> 'omitted'**
  
- 0c61540
  📍 **add integration test showing that pledge is correctly discovered**

  
# Comments

<!-- Additional comments or screenshots to attach if any -->

![Screenshot from 2020-06-25 18-17-08](https://user-images.githubusercontent.com/5680256/85758192-63cd9a80-b710-11ea-8fd6-f256ea68d2b1.png)

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Assign the PR to a corresponding milestone
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: KtorZ <[email protected]>
iohk-bors bot added a commit that referenced this issue Jun 26, 2020
@iohk-bors @KtorZ
Merge #1800
58d995d 
1800: wire pool's 'pledge' from the registration certificate unto the Api r=KtorZ a=KtorZ

# Issue Number

<!-- Put here a reference to the issue this PR relates to and which requirements it tackles -->

#1719

# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- 027ce66
  📍 **wire pool's 'pledge' from the registration certificate unto the Api**
  
- 37384c6
  📍 **fix typo in swagger documentation 'ommitted' -> 'omitted'**
  
- 0c61540
  📍 **add integration test showing that pledge is correctly discovered**

  
# Comments

<!-- Additional comments or screenshots to attach if any -->

![Screenshot from 2020-06-25 18-17-08](https://user-images.githubusercontent.com/5680256/85758192-63cd9a80-b710-11ea-8fd6-f256ea68d2b1.png)

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Assign the PR to a corresponding milestone
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: KtorZ <[email protected]>
@piotr-iohk
Copy link
Contributor

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Anviking Anviking

@KtorZ KtorZ

Labels
None yet
Projects
None yet
Milestone
(ADP-311) List stake pools
Development

No branches or pull requests
3 participants
@Anviking @KtorZ @piotr-iohk