You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We are returning 403 and error message when trying to migrate the wallets that are empty or contain only dust, however when calculating migration cost for such wallets we return 200 and migration cost = 0. This is somewhat inconsistent. We should be returning 403 and error message when calculating such migration cost too.
1008: Additional tests for migrating and calculating migration cost for wallets containing only dust r=piotr-iohk a=piotr-iohk
# Issue Number
#779#1007
# Overview
<!-- Detail in a few bullet points the work accomplished in this PR -->
- [ ] Added additional tests for attempting to migrate and calculate migration cost for dust wallets. Those special wallets added to `genesis.yaml`
# Comments
<!-- Additional comments or screenshots to attach if any -->
<!--
Don't forget to:
✓ Self-review your changes to make sure nothing unexpected slipped through
✓ Assign yourself to the PR
✓ Assign one or several reviewer(s)
✓ Once created, link this PR to its corresponding ticket
✓ Acknowledge any changes required to the Wiki
-->
Co-authored-by: Piotr Stachyra <[email protected]>
Co-authored-by: Pawel Jakubas <[email protected]>
Context
#989 (comment)
We are returning
403
and error message when trying to migrate the wallets that are empty or contain only dust, however when calculating migration cost for such wallets we return200
and migration cost =0
. This is somewhat inconsistent. We should be returning403
and error message when calculating such migration cost too.Note: for instance for estimating cost of transaction that is impossible to make due to insufficient funds, we return
403
-> https://github.com/input-output-hk/cardano-wallet/blob/master/lib/core-integration/src/Test/Integration/Scenario/API/Transactions.hs#L930-L951Steps to Reproduce
BYRON_CALCULATE_02
integration test -> https://github.com/input-output-hk/cardano-wallet/blob/master/lib/core-integration/src/Test/Integration/Scenario/API/ByronWallets.hs#L154-L163Expected behavior
We should return
403
and message (perhaps the same as when migrating such wallet):Actual behavior
Currently it passes, asserts for
0
calculated cost.Resolution Plan
PR
master
QA
BYRON_CALCULATE_02
integration tests.The text was updated successfully, but these errors were encountered: