From bc3e17131cb5fc5e00d0bf2f6c405fb3c9a486cd Mon Sep 17 00:00:00 2001 From: Johannes Lund Date: Fri, 1 Mar 2019 13:42:25 +0100 Subject: [PATCH 1/3] Add .stylish-haskell.yaml According to the proposed configuration https://github.com/input-output-hk/cardano-wallet/wiki/Coding-Standards#stylish-haskell-is-used-to-format-grouped-imports--language-pragmas --- .stylish-haskell.yaml | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 .stylish-haskell.yaml diff --git a/.stylish-haskell.yaml b/.stylish-haskell.yaml new file mode 100644 index 00000000000..84bd7425aeb --- /dev/null +++ b/.stylish-haskell.yaml @@ -0,0 +1,22 @@ +# Stylish-haskell configuration file +# +# See `stylish-haskell --defaults` or +# https://github.com/jaspervdj/stylish-haskell/blob/master/data/stylish-haskell.yaml +# for usage. + +columns: 80 # Should match .editorconfig +steps: + - imports: + align: none + empty_list_align: inherit + list_align: new_line + list_padding: 4 + long_list_align: new_line_multiline + pad_module_names: false + separate_lists: true + space_surround: true + + - language_pragmas: + align: false + remove_redundant: true + style: vertical From acb4ccf386524e25c644bca4c8677bbe5e2fdb5e Mon Sep 17 00:00:00 2001 From: Johannes Lund Date: Fri, 1 Mar 2019 13:43:00 +0100 Subject: [PATCH 2/3] Add .hlint.yaml Extended from the default config, according to the proposal: https://github.com/input-output-hk/cardano-wallet/wiki/Coding-Standards#we-use-hlint-as-a-linter --- .hlint.yaml | 82 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 82 insertions(+) create mode 100644 .hlint.yaml diff --git a/.hlint.yaml b/.hlint.yaml new file mode 100644 index 00000000000..51463829950 --- /dev/null +++ b/.hlint.yaml @@ -0,0 +1,82 @@ +# HLint configuration file +# https://github.com/ndmitchell/hlint +########################## + +# This file contains a template configuration file, which is typically +# placed as .hlint.yaml in the root of your project + + +# Specify additional command line arguments +# +# - arguments: [--color, --cpp-simple, -XQuasiQuotes] + + +# Control which extensions/flags/modules/functions can be used +# +# - extensions: +# - default: false # all extension are banned by default +# - name: [PatternGuards, ViewPatterns] # only these listed extensions can be used +# - {name: CPP, within: CrossPlatform} # CPP can only be used in a given module +# +# - flags: +# - {name: -w, within: []} # -w is allowed nowhere +# +# - modules: +# - {name: [Data.Set, Data.HashSet], as: Set} # if you import Data.Set qualified, it must be as 'Set' +# - {name: Control.Arrow, within: []} # Certain modules are banned entirely +# +# - functions: +# - {name: unsafePerformIO, within: []} # unsafePerformIO can only appear in no modules + +- modules: + # Enforce some common qualified imports aliases across the codebase + - {name: [Data.Aeson, Data.Aeson.Types], as: Aeson} + - {name: [Data.ByteArray], as: BA} + - {name: [Data.ByteString.Base16], as: B16} + - {name: [Data.ByteString.Char8], as: B8} + - {name: [Data.ByteString.Lazy], as: BL} + - {name: [Data.ByteString], as: BS} + - {name: [Data.Foldable], as: F} + - {name: [Data.List.NonEmpty], as: NE} + - {name: [Data.List], as: L} + - {name: [Data.Map.Strict], as: Map} + - {name: [Data.Sequence], as: Seq} + - {name: [Data.Set, Data.HashSet], as: Set} + - {name: [Data.Text, Data.Text.Encoding], as: T} + - {name: [Data.Vector], as: V} + +# Ignore some build-in rules +- ignore: {name: "Reduce duplication"} # This is a decision left to developers and reviewers +- ignore: {name: "Redundant bracket"} # Not everyone knows precedences of every operators in Haskell. Brackets help readability. +- ignore: {name: "Redundant do"} # Just an annoying hlint built-in, GHC may remove redundant do if he wants + + +# Add custom hints for this project +# +# Will suggest replacing "wibbleMany [myvar]" with "wibbleOne myvar" +# - error: {lhs: "wibbleMany [x]", rhs: wibbleOne x} + + +# Turn on hints that are off by default +# +# Ban "module X(module X) where", to require a real export list +# - warn: {name: Use explicit module export list} +# +# Replace a $ b $ c with a . b $ c +# - group: {name: dollar, enabled: true} +# +# Generalise map to fmap, ++ to <> +# - group: {name: generalise, enabled: true} + + +# Ignore some builtin hints +# - ignore: {name: Use let} +# - ignore: {name: Use const, within: SpecialModule} # Only within certain modules + + +# Define some custom infix operators +# - fixity: infixr 3 ~^#^~ + + +# To generate a suitable file for HLint do: +# $ hlint --default > .hlint.yaml From a29aa1575413f62ac45cc8b5838376defb6fa967 Mon Sep 17 00:00:00 2001 From: Johannes Lund Date: Mon, 4 Mar 2019 12:19:30 +0100 Subject: [PATCH 3/3] Run stylish --- app/server/Main.hs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/server/Main.hs b/app/server/Main.hs index 1451720208e..fee4b8c0923 100644 --- a/app/server/Main.hs +++ b/app/server/Main.hs @@ -1,7 +1,8 @@ module Main where +import Cardano.Wallet + ( sayHello ) import Prelude -import Cardano.Wallet (sayHello) main :: IO () main = sayHello