Skip to content

Commit

Permalink
Merge #1810
Browse files Browse the repository at this point in the history
1810: discard metadata URL based on their hash, not URLs r=rvl a=KtorZ

# Issue Number

<!-- Put here a reference to the issue this PR relates to and which requirements it tackles -->

#1805 

# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] I have changed the SQLite filtering to discard metadata URL based on their hash, not URLs


<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Assign the PR to a corresponding milestone
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: KtorZ <[email protected]>
  • Loading branch information
iohk-bors[bot] and KtorZ authored Jun 28, 2020
2 parents d1d635f + c702f82 commit 0242560
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/core/src/Cardano/Pool/DB/Sqlite.hs
Original file line number Diff line number Diff line change
Expand Up @@ -273,9 +273,9 @@ newDBLayer trace fp = do
, "FROM", metadata
, ")"
, "AND"
, metadataUrl, "NOT", "IN" -- Recently failed urls
, metadataHash, "NOT", "IN" -- Recently failed urls
, "("
, "SELECT", metadataUrl
, "SELECT", metadataHash
, "FROM", fetchAttempts
, "WHERE", retryAfter, ">=", "datetime('now')"
, ")"
Expand Down

0 comments on commit 0242560

Please sign in to comment.