Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CIP-100 | Canonical example is wrong #781

Closed
kderme opened this issue Mar 13, 2024 · 4 comments
Closed

CIP-100 | Canonical example is wrong #781

kderme opened this issue Mar 13, 2024 · 4 comments

Comments

@kderme
Copy link
Contributor

kderme commented Mar 13, 2024

The canonical form of the example is wrong, for example it misses the hashAlgorithm key
@Ryun1
Copy link
Collaborator

Ryun1 commented Mar 13, 2024

Good spot!

I will get a PR to fix this one shortly.

@Ryun1 Ryun1 mentioned this issue Mar 13, 2024
Merged
@Ryun1
Copy link
Collaborator

Ryun1 commented Mar 13, 2024

See #782

@Quantumplation
Copy link
Contributor

It is not intended to include the hashAlgorithm key; see the comment I just left in #782

@kderme
Copy link
Contributor Author

kderme commented Sep 24, 2024

The example was fixed, thank you

@kderme kderme closed this as completed Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Quantumplation @kderme @Ryun1