Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SteppedAnimatedMedia]: SSR is broken after moving up to NodeJS v22 #6330

Closed
2 tasks done
flannanl opened this issue Oct 30, 2024 · 4 comments
Closed
2 tasks done

[SteppedAnimatedMedia]: SSR is broken after moving up to NodeJS v22 #6330

flannanl opened this issue Oct 30, 2024 · 4 comments
Labels
Sev 2 Aspects of design is broken and impedes users in a significant way, but has workaround. stale 🍞 status: waiting for author 💬 status: won’t fix 🔚 This will not be worked on type: bug 🐛 Something isn't working

Comments

@flannanl
Copy link

flannanl commented Oct 30, 2024

Package

Carbon for IBM Products

Description

Moving up to NodeJS v22 now breaks SSR badly. I cannot even start my service.

The SteppedAnimatedMedia component is referencing lottie-web and it seems on NodeJS v22, some of its functions that using the document object are not called even at the package import.

[2024-10-30T11:49:22.461] [FATAL] @console/console-platform-express-setup - document is not defined ReferenceError: document is not defined
    at createTag (/Users/flannanl/Git/projects-ui/node_modules/lottie-web/build/player/lottie.js:30:5)
    at /Users/flannanl/Git/projects-ui/node_modules/lottie-web/build/player/lottie.js:1316:20
    at /Users/flannanl/Git/projects-ui/node_modules/lottie-web/build/player/lottie.js:1323:6
    at /Users/flannanl/Git/projects-ui/node_modules/lottie-web/build/player/lottie.js:1540:4
    at /Users/flannanl/Git/projects-ui/node_modules/lottie-web/build/player/lottie.js:2:83
    at Object.<anonymous> (/Users/flannanl/Git/projects-ui/node_modules/lottie-web/build/player/lottie.js:5:3)
    at Module._compile (node:internal/modules/cjs/loader:1546:14)
    at Object..js (node:internal/modules/cjs/loader:1689:10)
    at Module.load (node:internal/modules/cjs/loader:1318:32)
    at Function._load (node:internal/modules/cjs/loader:1128:12)
    at TracingChannel.traceSync (node:diagnostics_channel:315:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:218:24)
    at Module.require (node:internal/modules/cjs/loader:1340:12)
    at require (node:internal/modules/helpers:141:16)
    at Object.<anonymous> (/Users/flannanl/Git/projects-ui/node_modules/@carbon/ibm-products/lib/components/SteppedAnimatedMedia/SteppedAnimatedMedia.js:12:14)
    at Module._compile (node:internal/modules/cjs/loader:1546:14)

Component(s) impacted

See the stack trace in the description.

Browser

No response

@carbon/ibm-products (previously @carbon/ibm-cloud-cognitive) version

2.47.0

Suggested Severity

Severity 1 = The design is broken in a critical way that blocks users from completing tasks or damages the brand. Affects major functionality, no workaround.

Product/offering

IBM Cloud Projects

CodeSandbox or Stackblitz example

N/A

Steps to reproduce the issue (if applicable)

No response

Release date (if applicable)

No response

Code of Conduct

@flannanl
Copy link
Author

Looks like the crash is due to the new experimental feature in NodeJS v22: https://nodejs.org/docs/latest-v22.x/api/globals.html#navigator.

Since there is a way to disable the feature for now, I'm okay to lower the severity to 2.

@elycheea
Copy link
Contributor

We’re actually looking remove decouple lottie-web from our implementation #6366. Linking the issue so we can keep you posted.

@elycheea elycheea added type: bug 🐛 Something isn't working Sev 2 Aspects of design is broken and impedes users in a significant way, but has workaround. status: waiting for author 💬 and removed status: needs triage 🕵️‍♀️ labels Nov 11, 2024
@elycheea elycheea moved this from Needs triage 🧐 to Next in Carbon for IBM Products Nov 11, 2024
Copy link
Contributor

This issue is stale because it has been open for 7 days with no activity.
Remove the stale label or add a comment, otherwise this issue will be closed in 7 days.

Copy link
Contributor

This issue was closed because it has received no activity for 14 days.

@github-actions github-actions bot added the status: won’t fix 🔚 This will not be worked on label Nov 27, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 27, 2024
@github-project-automation github-project-automation bot moved this from Next to Done 🚀 in Carbon for IBM Products Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sev 2 Aspects of design is broken and impedes users in a significant way, but has workaround. stale 🍞 status: waiting for author 💬 status: won’t fix 🔚 This will not be worked on type: bug 🐛 Something isn't working
Projects
Status: Done 🚀
Development

No branches or pull requests

2 participants