Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generate component script to use TypeScript #4627

Closed
Tracked by #4232
matthewgallo opened this issue Mar 27, 2024 · 3 comments · Fixed by #5817
Closed
Tracked by #4232

Update generate component script to use TypeScript #4627

matthewgallo opened this issue Mar 27, 2024 · 3 comments · Fixed by #5817
Assignees
Labels
adopter: automation Issues connected to work that accelerates IBM's automation offerings. adopter: data & ai Issues connected to work that accelerates IBM's Data & AI offerings. adopter: security Issues connected to work that accelerates IBM's Security offerings. adopter: sustainability Issues connected to work that accelerates IBM's sustainability offerings. area: typescript type: infrastructure 🤖 Issues related to devops, builds, packaging
Milestone

Comments

@matthewgallo
Copy link
Member

What will this achieve?

When we create new components, there is a generate component script that can be run to scaffold the correct setup of files, configuring package-settings, exporting the new component. This is an issue to think about when the right time is to have the actual component itself moved from .js to .tsx file.

I don't think we need to set a timeline on this for now, but wanted to make sure it's something we plan for later on.

@github-project-automation github-project-automation bot moved this to Needs triage 🧐 in Carbon for IBM Products Mar 27, 2024
@sstrubberg sstrubberg added type: infrastructure 🤖 Issues related to devops, builds, packaging adopter: security Issues connected to work that accelerates IBM's Security offerings. adopter: data & ai Issues connected to work that accelerates IBM's Data & AI offerings. adopter: automation Issues connected to work that accelerates IBM's automation offerings. adopter: sustainability Issues connected to work that accelerates IBM's sustainability offerings. and removed status: needs triage 🕵️‍♀️ labels Apr 1, 2024
@sstrubberg sstrubberg added this to the 2024 Q2 milestone Apr 1, 2024
@elycheea elycheea moved this from Needs triage 🧐 to Icebox 🧊 in Carbon for IBM Products May 7, 2024
@elycheea elycheea moved this from Icebox 🧊 to Next in Carbon for IBM Products May 7, 2024
@elycheea
Copy link
Contributor

elycheea commented May 7, 2024

Agree. Putting this in the icebox for now since in some previous discussions, we said not to require TypeScript for new components. We might be reaching the point soon where we should start shifting to TypeScript on default though. 🤔

@elycheea elycheea moved this from Next to Backlog 🌋 in Carbon for IBM Products Jul 15, 2024
@elycheea elycheea moved this from Backlog 🌋 to Needs triage 🧐 in Carbon for IBM Products Jul 15, 2024
@ljcarot ljcarot modified the milestones: 2024 Q2, 2024 Q3 Jul 17, 2024
@elycheea elycheea moved this from Needs triage 🧐 to Backlog 🌋 in Carbon for IBM Products Jul 22, 2024
@AlexanderMelox
Copy link
Contributor

Are we still keeping PropTypes in the generate or just Typescript props?

DISPLAY_NAME.propTypes = {
  /**
   * Provide the contents of the DISPLAY_NAME.
   */
  children: PropTypes.node.isRequired,

  /**
   * Provide an optional class to be applied to the containing node.
   */
  className: PropTypes.string,

  /* TODO: add types and DocGen for all props. */
};

@matthewgallo
Copy link
Member Author

For now we'll keep both until something more concrete has been decided from #4466

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adopter: automation Issues connected to work that accelerates IBM's automation offerings. adopter: data & ai Issues connected to work that accelerates IBM's Data & AI offerings. adopter: security Issues connected to work that accelerates IBM's Security offerings. adopter: sustainability Issues connected to work that accelerates IBM's sustainability offerings. area: typescript type: infrastructure 🤖 Issues related to devops, builds, packaging
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants