Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataSpreadsheet refactor #4186

Closed
4 tasks done
elycheea opened this issue Jan 31, 2024 · 0 comments
Closed
4 tasks done

DataSpreadsheet refactor #4186

elycheea opened this issue Jan 31, 2024 · 0 comments

Comments

@elycheea
Copy link
Contributor

elycheea commented Jan 31, 2024

Followup from DataSpreadsheet release review that we never got around to closing out.

We can recheck current code coverage, but believe @matthewgallo and @davidmenendez both contributed to get this to about 80-90%

  • a lot of missing code coverage
  • handleKeyPress has a lot of redundant code
  • not a deal breaker, but considering how large the file is a lot of the handler initializers may want to be moved into separate util or hook files at some point
  • if you command click the same 2 cells over and over again they just keep getting added to the selection
  • isHoldingCommandKey is defined a few different times, so it should probably be a utility

Originally posted by @davidmenendez in #2324 (comment)

Tasks

Preview Give feedback
  1. component: DataSpreadsheet version: 2
  2. component: DataSpreadsheet version: 2
  3. component: DataSpreadsheet version: 2
  4. component: DataSpreadsheet status: needs triage 🕵️‍♀️ version: 2
@github-project-automation github-project-automation bot moved this to Needs triage 🧐 in Carbon for IBM Products Jan 31, 2024
@elycheea elycheea moved this from Needs triage 🧐 to Needs refinement 🤓 in Carbon for IBM Products Feb 1, 2024
@elycheea elycheea moved this from Needs refinement 🤓 to In progress in Carbon for IBM Products Feb 15, 2024
@amal-k-joy amal-k-joy moved this from In progress to Done 🚀 in Carbon for IBM Products Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants