You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Followup from DataSpreadsheet release review that we never got around to closing out.
We can recheck current code coverage, but believe @matthewgallo and @davidmenendez both contributed to get this to about 80-90%
a lot of missing code coverage
handleKeyPress has a lot of redundant code
not a deal breaker, but considering how large the file is a lot of the handler initializers may want to be moved into separate util or hook files at some point
if you command click the same 2 cells over and over again they just keep getting added to the selection
isHoldingCommandKey is defined a few different times, so it should probably be a utility
Followup from DataSpreadsheet release review that we never got around to closing out.
We can recheck current code coverage, but believe @matthewgallo and @davidmenendez both contributed to get this to about 80-90%
a lot of missing code coveragehandleKeyPress
has a lot of redundant codeisHoldingCommandKey
is defined a few different times, so it should probably be a utilityOriginally posted by @davidmenendez in #2324 (comment)
Tasks
handleKeyPress
#4187isHoldingCommandKey
#4188The text was updated successfully, but these errors were encountered: