Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AboutModal: Remove 'theme' prop #384

Closed
1 of 2 tasks
dcwarwick opened this issue Mar 1, 2021 · 0 comments · Fixed by #427
Closed
1 of 2 tasks

AboutModal: Remove 'theme' prop #384

dcwarwick opened this issue Mar 1, 2021 · 0 comments · Fixed by #427
Assignees
@dcwarwick

Comments

@dcwarwick
Copy link
Contributor

dcwarwick commented Mar 1, 2021 •
edited
Loading

The 'theme' prop is too restrictive, as there are more themes in Carbon than it makes available. However, it is not needed at all because the client code can apply any desired Carbon theme to the modal to provide the design they require.

  • Remove the 'theme' prop from the AboutModal component
  • Add notes and code samples to the doc showing how the AboutModal can be set to a different theme than the surrounding UI
@dcwarwick dcwarwick mentioned this issue Mar 1, 2021
Closed
3 tasks
@dcwarwick dcwarwick changed the title Remove 'theme' prop from About Modal AboutModal: Remove 'theme' prop Mar 2, 2021
This was referenced Mar 2, 2021
Merged
Closed
@dcwarwick dcwarwick self-assigned this Mar 2, 2021
@dcwarwick dcwarwick mentioned this issue Mar 10, 2021
Merged
@kodiakhq kodiakhq bot closed this as completed in #427 Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dcwarwick dcwarwick

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: revamp stories and add code sample dcwarwick/ibm-cloud-cognitive
1 participant
@dcwarwick