-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datagrid design review: Toolbar #3117
Comments
@Ashley-Bock can you take this one? |
@kristastarr Feel free to remove any checks that don’t apply. Accessibility reviewKeyboardLevel 1 - see comments for items needing further attention
Level 2
Dynamic updatesLevel 2
Text and non-textLevel 3
|
1. Pop-out styling
2. Order of sizes listed
3. Toolbar height
|
Standards
Pattern and behavior
Storybook
|
|
@Ashley-Bock @matthewgallo So I went looking to figure out whether I think anything that drops down from the toolbar should be considered a “disclosure”1.
So based on this, I think the original design with the Footnotes
|
Some comments about keyboard accessibility - mostly related to Settings. I tried to capture in screen recording.
toolbar.screen.recording.mov
|
Tested with Mac Voiceover - everything except Settings works well. For Settings, after you click/activate the button, there is no information about the popover and it's status of open/closed, or it's contents and how to interact with them, so need to add some aria labels here. |
Documented in the new issue (#3241).
I wasn’t able to replicate this. Were you using a specific browser?
No specific tasks for this one at this time but hopefully we’ll have a better idea about the approach as more people use the component.
I believe this is actually the whole data table body is its own tab stop. Don’t recall if there was a specific reason for it, but open to more discussion on whether to change that behavior. (Might have implications in other stories though.)
Not an issue with the Datagrid in particular — believe this came from an update in the Carbon buttons but should be something we can address separately. I think both of these stem from the
Not prioritizing these for now since these will be replaced with the Carbon |
Design review
Standards
component developer
Pattern and behavior
maintainer
maintainer
maintainer(s)
currently set Carbon theme.
with Carbon set tokens (unless otherwise specified by the pattern)
views
Storybook
be used
Tasks
The text was updated successfully, but these errors were encountered: