Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Tearsheet> and <CreateTearsheet> have different default value for verticalPosition props #2980

Closed
1 of 3 tasks
joshualiu opened this issue May 10, 2023 · 5 comments
Closed
1 of 3 tasks

Comments

@joshualiu
Copy link

joshualiu commented May 10, 2023

What package(s) are you using?

  • Carbon for IBM Products (or Carbon for IBM Cloud & Cognitive)
  • Legacy/CDAI
  • Legacy/Security

Detailed description

Describe in detail the issue you're having.

Both <Tearsheet> and <CreateTearsheet> components from ibm-products have verticalPosition props.
For <Tearsheet>, the default value is lower and marked as deprecated, while for <CreateTearsheet> the value is normal.
https://carbon-for-ibm-products.netlify.app/?path=/docs/ibm-products-components-tearsheet-tearsheet--tearsheet#component-api
https://carbon-for-ibm-products.netlify.app/?path=/docs/ibm-products-patterns-create-flows-createtearsheet--multi-step-tearsheet#component-api

Design doc: https://pages.github.ibm.com/cdai-design/pal/components/tearsheet/usage/#placement says to keep 88px from the top. Which I assume <CreateTearsheet> needs to be updated.

Steps to reproduce the issue

refer to the storybook links above

Additional information

Acceptance criteria

Preview Give feedback
No tasks being tracked yet.
@joshualiu joshualiu added the type: bug 🐛 Something isn't working label May 10, 2023
@elycheea
Copy link
Contributor

elycheea commented Jun 1, 2023

@joshualiu Would like to contribute the fix for this? @matthewgallo says it seems like verticalPosition is deprecated so should be straightforward to fix. 🙂

@joshualiu
Copy link
Author

@elycheea Sure! Happy to!

@elycheea
Copy link
Contributor

Just documenting that #3865 was a related issue. We did not change the defaults, but when addressing the Storybook issue, did notice that normal and lower may both be relevant, depending if teams are actually using PageHeader with or without breadcrumbs.

Still, it would still be good fix to have our defaults consistent longer term.

@github-project-automation github-project-automation bot moved this to Needs triage 🧐 in Carbon for IBM Products Dec 15, 2023
@elycheea elycheea moved this from Needs triage 🧐 to Community backlog 🚞 in Carbon for IBM Products Dec 15, 2023
@elycheea elycheea added the needs: design opinion Design question needs opinion from designer label Jan 11, 2024
@elycheea elycheea moved this from Community backlog 🚞 to Needs refinement 🤓 in Carbon for IBM Products Jan 11, 2024
@elycheea
Copy link
Contributor

verticalPosition was intended to be deprecated ... we should verify if this is still valid to determine whether to actually deprecate and just use the same default or allow both versions but also set a common default.

@elycheea elycheea moved this from Needs refinement 🤓 to Later 🏔️ in Carbon for IBM Products Feb 15, 2024
@sstrubberg sstrubberg moved this from Later 🏔️ to Backlog 🌋 in Carbon for IBM Products May 14, 2024
@ljcarot ljcarot removed good first issue 🌱 needs: design opinion Design question needs opinion from designer labels Jan 6, 2025
@RichKummer
Copy link

@joshualiu – were looking to fix this discrepancy in the next version of Tearsheet and CreateTearsheet. Tracked under #6127

@github-project-automation github-project-automation bot moved this from Backlog 🌋 to Done 🚀 in Carbon for IBM Products Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 🚀
Development

No branches or pull requests

4 participants