-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<Tearsheet>
and <CreateTearsheet>
have different default value for verticalPosition
props
#2980
Comments
@joshualiu Would like to contribute the fix for this? @matthewgallo says it seems like |
@elycheea Sure! Happy to! |
Just documenting that #3865 was a related issue. We did not change the defaults, but when addressing the Storybook issue, did notice that Still, it would still be good fix to have our defaults consistent longer term. |
|
@joshualiu – were looking to fix this discrepancy in the next version of |
What package(s) are you using?
Detailed description
Both
<Tearsheet>
and<CreateTearsheet>
components fromibm-products
haveverticalPosition
props.For
<Tearsheet>
, the default value islower
and marked as deprecated, while for<CreateTearsheet>
the value isnormal
.https://carbon-for-ibm-products.netlify.app/?path=/docs/ibm-products-components-tearsheet-tearsheet--tearsheet#component-api
https://carbon-for-ibm-products.netlify.app/?path=/docs/ibm-products-patterns-create-flows-createtearsheet--multi-step-tearsheet#component-api
Design doc: https://pages.github.ibm.com/cdai-design/pal/components/tearsheet/usage/#placement says to keep 88px from the top. Which I assume
<CreateTearsheet>
needs to be updated.Steps to reproduce the issue
refer to the storybook links above
Additional information
<Tearsheet>
: https://github.com/carbon-design-system/ibm-cloud-cognitive/blob/main_v1/packages/cloud-cognitive/src/components/Tearsheet/Tearsheet.js#L87<CreateTearsheet>
: https://github.com/carbon-design-system/ibm-cloud-cognitive/blob/main_v1/packages/cloud-cognitive/src/components/CreateTearsheet/CreateTearsheet.js#L316Acceptance criteria
The text was updated successfully, but these errors were encountered: