Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolbar that shrinks to overflow #182

Closed
11 of 14 tasks
lee-chase opened this issue Nov 2, 2020 · 6 comments
Closed
11 of 14 tasks

Toolbar that shrinks to overflow #182

lee-chase opened this issue Nov 2, 2020 · 6 comments
Assignees
@lee-chase
Labels
status: needs tests type: enhancement 💡 New feature or request

Comments

@lee-chase
Copy link
Member

lee-chase commented Nov 2, 2020 •
edited
Loading

ToolbarWithOverflow

Brief description

Toolbars like other components can have space restricted. This toolbar should collapse to a single overflow menu if there is not enough room for it to fit entirely, or on a property value being set.

Required by #59

Details

See responsive examples here

#59 (comment)

Links to other materials

e.g. sketch files, icons, images, prototypes

Design Maintainer(s)

  • Owner/main maintainer(s)
  • Second/backup maintainer(s)

Tasks

  • Initial review of design/existing code

Working in experimental package

  • Create a shell component which
    • Create ComponentName/ComponentName.js component file that renders props
      in raw form (no styling or sub components, plain text OK)
    • Adds prop-types with comments for DocGen to
      ComponentName/ComponentName.js
    • Add Doc file e.g. ComponentName.mdx with a brief description of the
      component.       Only used by page header
  • First engineering review/playback

Continuing in experimental package

  • Storybook - stories to cover design scenarios, story with long, min and
    max content, story to demonstrate right-to-left support, etc.
  • Doc tab in storybook derived from design docs with embedded stories where
    appropriate
  • Code to include prop-types with comments for automated DocGen
    documentation
  • Tests (written in React Test Library) to cover behavior from the
    documented in the components mdx file.

Review and promote

  • Design review
  • Add design review issues addressed, issues raised or discounted.
  • Engineering review - Submit PR to promote component to production package
  • All engineering issues addressed, issues raised or discounted.
@lee-chase
Copy link
Member Author

Duplicate or customisation of #38 ?

@lee-chase lee-chase self-assigned this Nov 5, 2020
@lee-chase
Copy link
Member Author

Similar overflow behaviour to #32 and as a result should probably be on hold in the short term to see an update from the existing tag overflow code. Required by #59

@lee-chase lee-chase removed the on HOLD label Nov 19, 2020
@lee-chase lee-chase removed their assignment Nov 19, 2020
@SimonFinney SimonFinney mentioned this issue Nov 21, 2020
Closed
@lee-chase lee-chase self-assigned this Jan 20, 2021
@andreagmann
Copy link

@lee-chase is this on hold or in progress? If on hold, could we move things out of "In progress"?

@lee-chase
Copy link
Member Author

Needs tests and documentation before moving forward.

Needs an update to use labels instead of tooltips in overflow. Will address today.

@andreagmann andreagmann added the type: enhancement 💡 New feature or request label Feb 18, 2021
@lee-chase
Copy link
Member Author

Now users labels just needs tests

@lee-chase
Copy link
Member Author

Tests added with #338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lee-chase lee-chase

Labels
status: needs tests type: enhancement 💡 New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andreagmann @lee-chase