Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React: Masthead - On tab, 'Platform' is not visible on portrait mode. #4140

Closed
Praveen-sr opened this issue Oct 6, 2020 · 0 comments
Closed

React: Masthead - On tab, 'Platform' is not visible on portrait mode. #4140

Praveen-sr opened this issue Oct 6, 2020 · 0 comments
Assignees
@kennylam
Labels
bug Something isn't working package: react Work necessary for the Carbon for IBM.com react components package severity 2 Affects major functionality, has a workaround
Milestone
Sprint 20-21

Comments

@Praveen-sr
Copy link

Detailed description

On iPad - iOS 13
Issue: Masthead - 'Platform' is not visible on portrait mode.

Note: On Landscape mode its seen.

Additional information

Actual (portrait mode):
image.png

Landscape mode:
image.png
@Praveen-sr Praveen-sr added bug Something isn't working severity 2 Affects major functionality, has a workaround labels Oct 6, 2020
@RobertaJHahn RobertaJHahn added the package: react Work necessary for the Carbon for IBM.com react components package label Oct 6, 2020
@RobertaJHahn RobertaJHahn added this to the Sprint 20-20 milestone Oct 6, 2020
@kennylam kennylam self-assigned this Oct 7, 2020
@kennylam kennylam mentioned this issue Oct 7, 2020
Merged
kodiakhq bot pushed a commit that referenced this issue Oct 7, 2020
@kennylam
fix(masthead): update platform name responsive css (#4165)
49adab5 
### Related Ticket(s)

#4140 

### Description

Fix masthead platform name to remain visible until hamburger menu appears. Note this issue can be reproduced in all browsers, not only tablet/mobile devices.

![Oct-07-2020 11-58-03](https://user-images.githubusercontent.com/909118/95356261-78373c80-0894-11eb-9b0e-c7d0ac2c432c.gif)


### Changelog

**Changed**

- update responsive css for masthead platform name

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: vanilla": Vanilla -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive, React (Expressive) -->
<!-- *** "RTL": React (RTL) -->
<!-- *** "feature flag": React (experimental) -->
@jeffchew jeffchew mentioned this issue Oct 8, 2020
Closed
ariellalgilmore pushed a commit to ariellalgilmore/carbon-for-ibm-dotcom that referenced this issue Oct 22, 2020
@kennylam @ariellalgilmore
fix(masthead): update platform name responsive css (carbon-design-sys…
d57daa1 
…tem#4165)

### Related Ticket(s)

carbon-design-system#4140 

### Description

Fix masthead platform name to remain visible until hamburger menu appears. Note this issue can be reproduced in all browsers, not only tablet/mobile devices.

![Oct-07-2020 11-58-03](https://user-images.githubusercontent.com/909118/95356261-78373c80-0894-11eb-9b0e-c7d0ac2c432c.gif)


### Changelog

**Changed**

- update responsive css for masthead platform name

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: vanilla": Vanilla -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive, React (Expressive) -->
<!-- *** "RTL": React (RTL) -->
<!-- *** "feature flag": React (experimental) -->
@kennylam kennylam mentioned this issue Oct 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kennylam kennylam

Labels
bug Something isn't working package: react Work necessary for the Carbon for IBM.com react components package severity 2 Affects major functionality, has a workaround
Projects
None yet
Milestone
Sprint 20-21
Development

No branches or pull requests
5 participants
@kennylam @jeffchew @ljcarot @RobertaJHahn @Praveen-sr