fix(feature-card-block-large): focus outline now wraps around card properly #4139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k-large-focus-issue
|
Deploy preview created for package Built with commit: a5134ed73bec710b0d663b7417c7d4c0bd78622d |
|
Deploy preview created for package Built with commit: a5134ed73bec710b0d663b7417c7d4c0bd78622d |
kennylam
reviewed
Oct 6, 2020
Comment on lines
37
to
38
| outline-width: 3px; | ||
| outline-offset: 1px; |
There was a problem hiding this comment.
Looks good @IgnacioBecerra. Small thing, can we put these styles into :focus to remain consistent with other component focus states.
kennylam
approved these changes
Oct 7, 2020
kennylam
added
hacktoberfest-accepted
Ready to merge
ariellalgilmore
pushed a commit
to ariellalgilmore/carbon-for-ibm-dotcom
that referenced
this pull request
Oct 22, 2020
…operly (carbon-design-system#4139) ### Related Ticket(s) carbon-design-system#3881 ### Description The previous FeatureCardBlockLarge wasn't focusing correctly due to reusing the `outline` values meant for the `Default` and `Medium` CardBlocks. Inserting custom values to the Large `:focus` state makes it fit more adequately. Before (notice bottom right):  After:  ### Changelog **New** - Added new `outline` values to `.bx--feature-card-block-large .bx--card:focus` <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "package: vanilla": Vanilla --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "package: styles": Carbon Expressive, React (Expressive) --> <!-- *** "RTL": React (RTL) --> <!-- *** "feature flag": React (experimental) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
#3881
Description
The previous FeatureCardBlockLarge wasn't focusing correctly due to reusing the
outlinevalues meant for theDefaultandMediumCardBlocks. Inserting custom values to the Large:focusstate makes it fit more adequately.Before (notice bottom right):
After:
Changelog
New
outlinevalues to.bx--feature-card-block-large .bx--card:focus