Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(locale-modal): reset upon close #3935

Merged
merged 3 commits into from
Sep 14, 2020

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Sep 14, 2020

Related Ticket(s)

Refs #3896.

Description

This change resets the region selection in <dds-locale-modal> when it's closed by user gesture.

Changelog

New

  • A mechanism to reset the region selection in <dds-locale-modal> when it's closed by user gesture.

This change resets the region selection in `<dds-locale-modal>` when
it's closed by user gesture.

Refs carbon-design-system#3896.
@asudoh asudoh added the package: web components Work necessary for the IBM.com Library web components package label Sep 14, 2020
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 14, 2020

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 14, 2020

Copy link
Member

@jeffchew jeffchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good add, thank you!

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Sep 14, 2020
@kodiakhq kodiakhq bot merged commit 1a406ad into carbon-design-system:master Sep 14, 2020
@asudoh asudoh deleted the locale-modal-reset branch September 14, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants