Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React: Promo banner (behind feature flag) #3928

Closed
5 tasks done
jeffchew opened this issue Sep 11, 2020 · 3 comments
Closed
5 tasks done

React: Promo banner (behind feature flag) #3928

jeffchew opened this issue Sep 11, 2020 · 3 comments
Assignees
@guilhermelMoraes
Labels
dev Needs some dev work feature flag package: react Work necessary for the Carbon for IBM.com react components package priority: medium
Milestone
Sprint 20-19

Comments

@jeffchew
Copy link
Member

jeffchew commented Sep 11, 2020 •
edited by guilhermelMoraes
Loading

User Story

As a [user role below]:
IBM.com Library developer

I need to:
create the Promo banner

so that I can:
provide the ibm.com adopter developers components they can use to build ibm.com web pages

Additional information

Screen Shot 2020-09-11 at 5 12 16 PM

Acceptance criteria

  • Built as a pure React component/variant
  • Build behind a feature flag
  • Include README for the react component and corresponding styles
  • Add any necessary stable selectors
  • A comment is posted in the Prod QA issue, tagging Praveen, when development is finished
@jeffchew jeffchew added package: react Work necessary for the Carbon for IBM.com react components package dev Needs some dev work priority: medium labels Sep 11, 2020
@jeffchew jeffchew added this to the Sprint 20-19 milestone Sep 11, 2020
@guilhermelMoraes
Copy link
Contributor

Screen Shot 2020-09-14 at 10 06 57

@jeffchew this was achieved by passing down an SVG to the heading prop of ContentItemHorizontal. The difference between the one in the Support page L0 and the one available in our library is the spacing between the copy and the CTA. Should we discuss with the team about creating a new pattern from scratch or just add a new variation to the ContentItemHorizontal?

@jeffchew
Copy link
Member Author

jeffchew commented Sep 14, 2020 •
edited
Loading

@guilhermelMoraes Yes, good idea, I think we can probably have this convo in a slack thread in the engineering channel.

@guilhermelMoraes guilhermelMoraes mentioned this issue Sep 14, 2020
Merged
@RobertaJHahn RobertaJHahn mentioned this issue Sep 14, 2020
Closed
4 tasks
@RobertaJHahn
Copy link

@guilhermelMoraes I just created the Prod QA testing issue (#3952). You can include the comment on that issue when you are finished.

kodiakhq bot pushed a commit that referenced this issue Sep 15, 2020
@guilhermelMoraes
feat(promo-banner): introducing new pattern (behind feature flag) (#3944
937f8c4 
)

### Related Ticket(s)

React: Promo banner (behind feature flag) #3928

### Description

This section first has appeared on the new [static Support page L0](https://www.ibm.com/testing/support/). Check out the [visual specs here](https://app.abstract.com/projects/7f83c114-7627-4169-8af7-6a85e7147ea6/branches/master/commits/latest/files/01ee3bd8-c63d-4b3b-bddb-aabaddb5c31d/layers/88A2BB62-9234-4F68-B238-BBA28C43B876?collectionId=c963cb53-73c2-42a5-af39-f5538e24c454&collectionLayerId=dd10dfb7-71be-4c98-9562-73c151d3236b).

### Changelog

**New**

- `PromoBanner` pattern;
@jeffchew jeffchew mentioned this issue Sep 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guilhermelMoraes guilhermelMoraes

Labels
dev Needs some dev work feature flag package: react Work necessary for the Carbon for IBM.com react components package priority: medium
Projects
None yet
Milestone
Sprint 20-19
Development

No branches or pull requests
3 participants
@jeffchew @guilhermelMoraes @RobertaJHahn