Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web Component: Develop LeadSpace of the React version - Group 1 #3561

Closed
8 tasks done
ibmdotcom-bot opened this issue Aug 12, 2020 · 0 comments
Closed
8 tasks done

Web Component: Develop LeadSpace of the React version - Group 1 #3561

ibmdotcom-bot opened this issue Aug 12, 2020 · 0 comments
Assignees
@annawen1
Labels
dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package priority: high sprint demo
Milestone
Sprint 20-21

Comments

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 12, 2020 •
edited by annawen1
Loading

User Story

As a [user role below]:
IBM.com Library developer

I need to:
create the LeadSpace

so that I can:
provide ibm.com adopter developers a web component version for every react version available in the ibm.com Library

Additional information

Acceptance criteria

  • Include README for the web component and corresponding styles
  • Create Web Components styles in styles package
  • No custom styles in web-components package
  • Do not create knobs in Storybook that include JSON objects
  • Break out Storybook stories into multiple variation stories, if applicable
  • Create codesandbox example under /packages/web-components/examples/codesandbox and include in README
  • Minimum 80% unit test coverage
  • A comment is posted in the Prod QA issue, tagging Praveen when development is finished
@ibmdotcom-bot ibmdotcom-bot added dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package priority: high labels Aug 12, 2020
@ibmdotcom-bot ibmdotcom-bot mentioned this issue Aug 12, 2020
Closed
5 tasks
@RobertaJHahn RobertaJHahn added this to the Sprint 20-17 milestone Aug 12, 2020
@RobertaJHahn RobertaJHahn mentioned this issue Sep 2, 2020
Closed
@RobertaJHahn RobertaJHahn changed the title Web Component: Develop LeadSpace of the React version Web Component: Develop LeadSpace of the React version - Group 1 Sep 9, 2020
@jeffchew jeffchew mentioned this issue Sep 11, 2020
Closed
@annawen1 annawen1 self-assigned this Sep 14, 2020
@annawen1 annawen1 mentioned this issue Sep 28, 2020
Merged
kodiakhq bot pushed a commit that referenced this issue Sep 28, 2020
@annawen1
fix(LeadSpace): simplify leadspace styles and remove BEM concatenatio…
a391262 
…n for web component creation (#4068)

### Related Ticket(s)

Web Component: Develop LeadSpace of the React version - Group 1 #3561

### Description

Simplify the leadspace styles for web component development

### Changelog

**Removed**

- remove most of the center leadspace specific classes and use parent center class selector instead
- remove BEM concatenation

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: vanilla": Vanilla -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive, React (Expressive) -->
<!-- *** "RTL": React (RTL) -->
<!-- *** "feature flag": React (experimental) -->
@annawen1 annawen1 reopened this Sep 29, 2020
@annawen1 annawen1 mentioned this issue Sep 30, 2020
Merged
ariellalgilmore pushed a commit to ariellalgilmore/carbon-for-ibm-dotcom that referenced this issue Oct 2, 2020
@annawen1 @ariellalgilmore
fix(LeadSpace): simplify leadspace styles and remove BEM concatenatio…
16edfbe 
…n for web component creation (carbon-design-system#4068)

### Related Ticket(s)

Web Component: Develop LeadSpace of the React version - Group 1 carbon-design-system#3561

### Description

Simplify the leadspace styles for web component development

### Changelog

**Removed**

- remove most of the center leadspace specific classes and use parent center class selector instead
- remove BEM concatenation

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: vanilla": Vanilla -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive, React (Expressive) -->
<!-- *** "RTL": React (RTL) -->
<!-- *** "feature flag": React (experimental) -->
kodiakhq bot pushed a commit that referenced this issue Oct 16, 2020
@annawen1
feat(leadspace): leadspace web component (#4084)
2ed27c5 
### Related Ticket(s)

Web Component: Develop LeadSpace of the React version - Group 1 #3561

### Description

LeadSpace web component

<img width="1469" alt="Screen Shot 2020-10-13 at 9 57 39 AM" src="https://user-images.githubusercontent.com/54281166/95870550-9db3c280-0d3a-11eb-9185-1a63fb0f377c.png">


### Changelog

**New**

- leadspace web component

**Changed**

- react version of leadspace restructured in order to accommodate how the web components version needs to be built
- leadspace styles (the centered styles moved under the main `bx--leadspace` class

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: vanilla": Vanilla -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive, React (Expressive) -->
<!-- *** "RTL": React (RTL) -->
<!-- *** "feature flag": React (experimental) -->
ariellalgilmore pushed a commit to ariellalgilmore/carbon-for-ibm-dotcom that referenced this issue Oct 22, 2020
@annawen1 @ariellalgilmore
feat(leadspace): leadspace web component (carbon-design-system#4084)
88881d7 
### Related Ticket(s)

Web Component: Develop LeadSpace of the React version - Group 1 carbon-design-system#3561

### Description

LeadSpace web component

<img width="1469" alt="Screen Shot 2020-10-13 at 9 57 39 AM" src="https://user-images.githubusercontent.com/54281166/95870550-9db3c280-0d3a-11eb-9185-1a63fb0f377c.png">


### Changelog

**New**

- leadspace web component

**Changed**

- react version of leadspace restructured in order to accommodate how the web components version needs to be built
- leadspace styles (the centered styles moved under the main `bx--leadspace` class

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: vanilla": Vanilla -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive, React (Expressive) -->
<!-- *** "RTL": React (RTL) -->
<!-- *** "feature flag": React (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@annawen1 annawen1

Labels
dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package priority: high sprint demo
Projects
None yet
Milestone
Sprint 20-21
Development

No branches or pull requests
3 participants
@RobertaJHahn @ibmdotcom-bot @annawen1