Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Icons: Update library (and Sketch kit) with new weather icons. #737

Closed
mjabbink opened this issue Feb 20, 2020 · 6 comments
Closed

UI Icons: Update library (and Sketch kit) with new weather icons. #737

mjabbink opened this issue Feb 20, 2020 · 6 comments
Labels
impact: medium Affects many users role: dev 🤖 severity: 2 Affects major functionality, has a workaround status: blocked 🙅‍♀️

Comments

@mjabbink
Copy link
Contributor

mjabbink commented Feb 20, 2020

There are 35 or more weather channel icons @conradennis created and are now in the repo but need to be added to library. The weather channel peeps are ready to use these bad boys.

64835280-1b6b-11ea-87d6-83821c03a723

@mjabbink mjabbink added impact: medium Affects many users role: dev 🤖 severity: 2 Affects major functionality, has a workaround labels Feb 20, 2020
@vpicone
Copy link
Contributor

vpicone commented Feb 20, 2020

@mjabbink they're in the Carbon repo but not released yet. When Carbon publishes their icons package we'll get the new icons automatically. We can't do anything until then.

@vpicone
Copy link
Contributor

vpicone commented Feb 20, 2020

Blocked by carbon-design-system/carbon#5398

@mjabbink
Copy link
Contributor Author

mjabbink commented Apr 1, 2020

They seem to also be in the library which is good. So they only still need to be added to the Sketch kit?

@vpicone
Copy link
Contributor

vpicone commented Apr 7, 2020

@mjabbink not sure, we don't interact with the sketch kit in the gatsby theme. I'd ask @laurenmrice and open an issue in the Carbon repo if these aren't in the sketch kit yet.

Gonna close this one, since the icons were added to Carbon and IDL.

@vpicone vpicone closed this as completed Apr 7, 2020
@laurenmrice
Copy link
Member

@mjabbink @vpicone Yes i am seeing those in the latest icon plugin generation that josh gave me to review, those will be in the sketch libraries once we release it. 👍🏻

@mjabbink
Copy link
Contributor Author

mjabbink commented Apr 7, 2020

Sweet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact: medium Affects many users role: dev 🤖 severity: 2 Affects major functionality, has a workaround status: blocked 🙅‍♀️
Projects
None yet
Development

No branches or pull requests

3 participants