Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In mobile the dropdown should be white #1109

Closed
mjabbink opened this issue Mar 26, 2021 · 3 comments · Fixed by #1126
Closed

In mobile the dropdown should be white #1109

mjabbink opened this issue Mar 26, 2021 · 3 comments · Fixed by #1126

Comments

@mjabbink
Copy link
Contributor

@mjabbink commented on Tue Mar 02 2021

https://www.ibm.com/design/language/typography/typeface

Dropdown should be white when the tabs change to dropdown in mobile:

Screen Shot 2021-03-02 at 10.05.56 PM.png

FYI: Master @sadekbazaraa


@sadekbazaraa commented on Wed Mar 03 2021

Thanks @mjabbink

@vpicone @alisonjoseph The bug is appearing on Subfamilies at the mobile breakpoint but works fine just below on Type tester

Correct at large break point
Screen Shot 2021-03-03 at 12 52 39 PM

Dropdown is incorrect once it hits mobile (should stay White, not Gray 10)
Screen Shot 2021-03-03 at 12 52 50 PM


@mjabbink commented on Wed Mar 03 2021

Good fix. I screen grabbed the wrong component! Thanks @sadekbazaraa!

@mjabbink
Copy link
Contributor Author

mjabbink commented Mar 26, 2021

closed https://github.com/carbon-design-system/design-language-website/issues/883 when moving this to Gatsby Theme. This is a Gatsby issue effecting all the Experience Guide, IDL and Carbon sites not just IDL.

@mjabbink
Copy link
Contributor Author

mjabbink commented Apr 2, 2021

Let’s please accomplish this sprint. Thanks @vpicone!

@mjabbink
Copy link
Contributor Author

@vpicone This issue still exists here (mobil). https://www.ibm.com/design/language/typography/typeface#subfamilies

IMG_0546

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant