Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double check for memory leaks #32

Open
photodow opened this issue Oct 2, 2020 · 0 comments
Open

Double check for memory leaks #32

photodow opened this issue Oct 2, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@photodow
Copy link
Contributor

photodow commented Oct 2, 2020

With all of the looping, and event listeners in this extension, it's very easy to see how a memory leak can be applied. I need to go in and do a quick audit and make sure everything is exiting correctly, and we're cleaning things up appropriately. Luckily no reports of any major performance issues yet.

Things to look for...

  • Exiting loops as soon as possible
  • Chrome event listeners aren't being called more than necessary, especially being defined inside react components
  • Removing event listeners
@photodow photodow added the bug Something isn't working label Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant