Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component expressive and theme #24

Open
photodow opened this issue Oct 1, 2020 · 0 comments
Open

Component expressive and theme #24

photodow opened this issue Oct 1, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@photodow
Copy link
Contributor

photodow commented Oct 1, 2020

If the information is available we should add metadata to each component in the component list whether it's an expressive component, and what theme it's using.

expressive

Here is one thought on how to do expressive, but I'm afraid it's not nuanced enough. For example Masthead is productive, but if this will run true on it.

function isExpressive() {
  Boolean(getComputedStyle(document.body).getPropertyValue("--cds-container-01"))
}

there is also a difference between container01 in expressive (2rem) and productive (1.5rem / container01). Might be able to leverage this.

Might also be worth talking to teams if there is a token we can contribute that says whether the component is expressive or not, or what theme it is.

Delayed due to sunsetting feature

@photodow photodow added the enhancement New feature or request label Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant