Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v3): Update devtools to carbon v11 & rebuild on vite #334

Draft
wants to merge 6 commits into
base: base
Choose a base branch
from

Conversation

andy-blum
Copy link
Member

@andy-blum andy-blum commented Sep 20, 2024

Closes #160 #158

This PR update the devtools codebase to build using vite & vite-plugin-web-extension. Vite is a modern build tool on top of rollup which runs faster than the previous webpack config.

Additionally, this PR updates the carbon dependencies to v11, opening the door to supporting the next generation of the Carbon Design System and IBM.com products and services.

Testing Instructions

The rebuild is being completed in /packages/webext and will eventually replace /packages/web-extension. The older package is left in place so components & scripts can be brought over one at a time.

To test the current state of the devtools, yarn install from the project root and then run yarn dev from /packages/webext. The web extension should build and launch in an automated chrome window.

@andy-blum
Copy link
Member Author

The extension currently doesn't actually do anything, but all three isolated worlds of the extension are running and communicating properly.

  • When the popup is opened, a message is sent
  • The background service worker detects that message and injects scripts/styles into the active tab
  • The scripts are able to run in the active tab and send a message back to the popup

Copy link
Collaborator

@motou motou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@mattrosno mattrosno removed their request for review October 8, 2024 14:40
@mattrosno
Copy link
Member

Hi @andy-blum - I removed myself as a reviewer. I'm not familiar with this code base and am not the best person to review these PRs. If I can help in any other way, e.g. account access, let me know!

@tay1orjones tay1orjones removed their request for review October 11, 2024 18:01
@tay1orjones
Copy link
Member

Hey I pulled myself off as reviewer for now, feel free to add me again once this is out of draft status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 3
4 participants