-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tile-group): refactor to functional component #9955
chore(tile-group): refactor to functional component #9955
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: df12a69 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61a925cf0fbb5f000791978b 😎 Browse the preview: https://deploy-preview-9955--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: df12a69 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61a925cf516c0c0007646dd2 😎 Browse the preview: https://deploy-preview-9955--carbon-components-react.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: df12a69 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61a925cfd71ad90008bc8940 😎 Browse the preview: https://deploy-preview-9955--carbon-elements.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Hey @motou looks like some of the tests are failing. Do you have time to fix this in the next few days? It'll be ready to merge once that's fixed. |
@jnm2377 yes sure. I will try to find some time today to fix the test errors |
hi @motou just wanted to check in on this and see how it's going |
Sorry for the delay. I will find some time this week to fix the failing unit tests |
@all-contributors please add @motou for code and doc ✨ |
I've put up a pull request to add @motou! 🎉 |
Hey @motou looks like this PR has gone stale. Just wanted to check in to see if you were still working on this. I'll be closing it at the end of the week otherwise. Thanks! |
Ref #9712
Refactor the TileGroup component to the functional component using
React.forwardRef
to ensure refs were being forwarded appropriately.Notes
getDerivedStateFromProps
is modified using the recommendation in #9712.renderLegend
is moved into the rendering method.Testing / Reviewing
yarn start:v11
frompackages/react
Todo