Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tile-group): refactor to functional component #9955

Closed
wants to merge 12 commits into from
Closed

chore(tile-group): refactor to functional component #9955

wants to merge 12 commits into from

Conversation

motou
Copy link
Contributor

@motou motou commented Oct 26, 2021

Ref #9712

Refactor the TileGroup component to the functional component using React.forwardRef to ensure refs were being forwarded appropriately.

  • TileGroup

Notes

getDerivedStateFromProps is modified using the recommendation in #9712. renderLegend is moved into the rendering method.

Testing / Reviewing

Todo

  • re-write tests to use RTL

@motou motou requested a review from a team as a code owner October 26, 2021 21:57
@motou motou requested review from joshblack and dakahn October 26, 2021 21:57
@motou motou changed the title chore(tile-group): refactor to functional comp chore(tile-group): refactor to functional component Oct 26, 2021
@netlify
Copy link

netlify bot commented Oct 26, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: df12a69

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61a925cf0fbb5f000791978b

😎 Browse the preview: https://deploy-preview-9955--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Oct 26, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: df12a69

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61a925cf516c0c0007646dd2

😎 Browse the preview: https://deploy-preview-9955--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Oct 26, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: df12a69

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61a925cfd71ad90008bc8940

😎 Browse the preview: https://deploy-preview-9955--carbon-elements.netlify.app

Copy link
Contributor

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jnm2377
Copy link
Contributor

jnm2377 commented Nov 2, 2021

Hey @motou looks like some of the tests are failing. Do you have time to fix this in the next few days? It'll be ready to merge once that's fixed.

@motou
Copy link
Contributor Author

motou commented Nov 3, 2021

@jnm2377 yes sure. I will try to find some time today to fix the test errors

@jnm2377
Copy link
Contributor

jnm2377 commented Nov 10, 2021

hi @motou just wanted to check in on this and see how it's going

@motou
Copy link
Contributor Author

motou commented Nov 18, 2021

hi @motou just wanted to check in on this and see how it's going

Sorry for the delay. I will find some time this week to fix the failing unit tests

@motou
Copy link
Contributor Author

motou commented Nov 18, 2021

@all-contributors please add @motou for code and doc ✨

@allcontributors
Copy link
Contributor

@motou

I've put up a pull request to add @motou! 🎉

@jnm2377
Copy link
Contributor

jnm2377 commented Nov 30, 2021

Hey @motou looks like this PR has gone stale. Just wanted to check in to see if you were still working on this. I'll be closing it at the end of the week otherwise. Thanks!

@jnm2377 jnm2377 closed this Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants