fix(tooltip): correct tooltipId prop name #6744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 140fabe |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 140fabe https://deploy-preview-6744--carbon-components-react.netlify.app |
emyarod
approved these changes
Aug 28, 2020
dakahn
approved these changes
Aug 28, 2020
joshblack
approved these changes
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time we update our jest snapshots we're seeing regenerated values on tooltips like
Recently in #6458 the new autogenerated value was added and it checks against an undocumented
idprop. We can correct our issue by changing all usages oftooltipIdtoid, but this seems to be an unintentional change that should instead be usingtooltipIdif one is passed.@emyarod could you confirm if this is correct?
Changelog
Changed