Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isActive style for HeaderMenu #9784

Closed
1 task done
RianTavares opened this issue Sep 30, 2021 · 3 comments · Fixed by #9785
Closed
1 task done

Add isActive style for HeaderMenu #9784

RianTavares opened this issue Sep 30, 2021 · 3 comments · Fixed by #9785
Labels
component: ui-shell proposal: accepted This request has gone through triaging and we are accepting PR's against it. type: enhancement 💡

Comments

@RianTavares
Copy link
Contributor

Summary

My suggestion is a design/development enhancement.
I would like to set a boolean prop to set a style for HeaderMenu when it's active like already is made for HeaderMenuItem component.

Example of enhancement result:
isactive2

Justification

As described in one item of W3 WAI (Web Accessibility Tutorials) it's important to:
"Convey menu items and their states by using color and other styling options. For example, alter the shape of a menu item, or add an icon, in addition to changing its color when it is selected."

I couldn't find a way to do this state change demonstration when a page inside the HeaderMenu is active, then I'm purposing this enhancement.

Desired UX and success metrics

Clear and consistent styling allows users to find and recognize menus more quickly. Such styling includes consistency in the behavior, appearance, and relative location on pages across a website.

I believe this enhancement will contribute to the user experience with the Header Menu as described above and, as is already done in the HeaderMenuItem component.
Also, this provides best-practice guidance on implementing accessibility for Menus.

HeaderMenuItem example:
tday

Required functionality

No response

Specific timeline issues / requests

No response

Available extra resources

No response

Code of Conduct

@RianTavares
Copy link
Contributor Author

PR created for this enhancement #9785

@matbiit
Copy link

matbiit commented Oct 1, 2021

I strongly agree with this idea! It will be have a huge impact in our solutions that using Carbon as Design System! Congrats @RianTavares for the idea and contribution!

@JulianaBerdeville
Copy link

That's such an interesting point raised by @RianTavares. It would definitely make it easier, accessible and even more accordingly with UX/UI principles and ideas.
I believe it would raise Carbon's excellency and facilitate the frontend development using Carbon as Design system.
Thanks for sharing the idea, @RianTavares! :)

@dakahn dakahn added component: ui-shell proposal: open This request has gone through triaging. We're determining whether we take this on or not. and removed status: needs triage 🕵️‍♀️ status: waiting for maintainer response 💬 labels Oct 4, 2021
@tay1orjones tay1orjones added proposal: accepted This request has gone through triaging and we are accepting PR's against it. and removed proposal: open This request has gone through triaging. We're determining whether we take this on or not. labels Oct 11, 2021
@kodiakhq kodiakhq bot closed this as completed in #9785 Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ui-shell proposal: accepted This request has gone through triaging and we are accepting PR's against it. type: enhancement 💡
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants