Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Modals are clipping combobox dropdowns #9732

Closed
2 tasks done
wkeese opened this issue Sep 24, 2021 · 5 comments
Closed
2 tasks done

[Bug]: Modals are clipping combobox dropdowns #9732

wkeese opened this issue Sep 24, 2021 · 5 comments
Labels

Comments

@wkeese
Copy link
Contributor

wkeese commented Sep 24, 2021

Package

carbon-components

Browser

Chrome

Package version

10.44

Description

Modals are now clipping the combobox dropdown, or at least, forcing it to remain in the modal.

This is a regression from #7698, which is no longer needed because the real problem was fixed in #9418.

So, the solution here (I believe) is to roll back #7698.

CodeSandbox example

https://codesandbox.io/s/cocky-lovelace-d95h5?file=/index.js

Steps to reproduce

Open https://codesandbox.io/s/cocky-lovelace-d95h5?file=/index.js, scroll down to the combobox, and open the dropdown.

Note that it does not overlay the modal's "Cancel" and "Submit" buttons like it should.

Code of Conduct

@tay1orjones
Copy link
Member

This appears to also be related to #7565? Maybe not though since this doesn't mention scrollable areas inside modal, just the modal itself.

@wkeese
Copy link
Contributor Author

wkeese commented Oct 6, 2021

Yeah, #7565 is more of a philosophical ticket whereas this is about a specific node/class. I added my thoughts to #7565 though.

@wkeese
Copy link
Contributor Author

wkeese commented Oct 25, 2021

Revision on my earlier comments:

In addition to rolling back #7698, can't you roll back #9418 and put the position:relative on the checkbox itself, or the immediate checkbox wrapper? You need to do that anyway to fix #9444.

It's best to avoid position:relative on ancestors of dropdowns.

@francinelucca
Copy link
Collaborator

is this and #7565 the same issue? if so, should we close one?

@tw15egan
Copy link
Collaborator

tw15egan commented Jun 1, 2023

Yeah @francinelucca they are encountering the same issue. It seems like the other issue has a bit more history / workarounds, so lets close this one in favor of that 👍🏻

@tw15egan tw15egan closed this as completed Jun 1, 2023
@github-project-automation github-project-automation bot moved this from ⏱ Backlog to ✅ Done in Design System Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

5 participants