Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Beta 1] Ecosystem Changes #9158

Closed
11 of 12 tasks
joshblack opened this issue Jul 10, 2021 · 2 comments
Closed
11 of 12 tasks

[Beta 1] Ecosystem Changes #9158

joshblack opened this issue Jul 10, 2021 · 2 comments
Milestone

Comments

@joshblack
Copy link
Contributor

joshblack commented Jul 10, 2021

Acceptance Criteria

  • A team must be able to install @carbon/react@beta
  • A team must be able to install @carbon/styles@beta
  • A team must be able to use a React component from @carbon/react
  • A team must be able to use styles from a scss entrypoint, either from @carbon/styles and @carbon/react
  • A team must be able to view the storybook documentation for @carbon/react
  • A team must be able to view migration docs for carbon-components to @carbon/styles

Checklist

@joshblack joshblack mentioned this issue Jul 12, 2021
2 tasks
@mattrosno mattrosno added this to the v11 Beta 1 milestone Jul 12, 2021
@joshblack joshblack added the Epic label Jul 12, 2021
@tay1orjones
Copy link
Member

A team must be able to view the storybook documentation for @carbon/react

Just want to note that the prop tables in the @carbon/react storybook aren't working, even when args/controls are configured. Looks like it's a limitation of react-docgen, storybookjs/storybook#10034 (comment)

It seems to fix we'll need to import components from a relative path instead of from carbon-components-react.

@shilman
Copy link

shilman commented Aug 11, 2021

@tay1orjones @joshblack happy to discuss workarounds for this limitation on the Storybook Discord if it's blocking https://discord.gg/storybook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants