Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ProgressBar to use Sass Modules #9075

Closed
tw15egan opened this issue Jun 30, 2021 · 0 comments · Fixed by #9148
Closed

Refactor ProgressBar to use Sass Modules #9075

tw15egan opened this issue Jun 30, 2021 · 0 comments · Fixed by #9148

Comments

@tw15egan
Copy link
Collaborator

This issue is for updating the ProgressBar to Sass Modules in the @carbon/styles package. In this refactor, we will:

Copy over styles for for the component to packages/styles/scss/components/progress-bar/_progress-bar.scss
Any additional files will live in the folder packages/styles/scss/components/progress-bar/
Create an _index.scss at packages/styles/scss/components/progress-bar/_index.scss
Create a test file at packages/styles/scss/components/tests/progress-bar.js
Add storybook to packages/carbon-react
The _index.scss should:

@forward the mixin and any variables from _progress-bar.scss
Include the styles from _progress-bar.scss by calling the mixin
The progress-bar-test.js file should test the following:

The Public API of the progress-bar/_index.scss file
Any configuration options that are present for the file
The _progress-bar.scss will then need to be refactored to use the new import paths and conventions. You can find common recipes here: #8899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant