Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the React-Router example to the latest version i.e. v5 or v6 #8885

Closed
sohamsshah opened this issue Jun 11, 2021 · 2 comments · Fixed by #8941
Closed

Update the React-Router example to the latest version i.e. v5 or v6 #8885

sohamsshah opened this issue Jun 11, 2021 · 2 comments · Fixed by #8941

Comments

@sohamsshah
Copy link
Contributor

Currently the React Router example is having version: react-router-dom": "^4.3.1.

Summary

  • Will update the example as there are some major API changes while migrating to v5 or above compared to v4.
  • Will also include Private/Protected Routing in the example itself so the developers can get better understanding overall.
  • Would love to add some newer components too in this example, so to keep things up to date.

Justification

As a developer exploring any open source library, one of the first things one searches for is example folder. This PR will help to keep things up-to-date!

Available extra resources

  • Can you affirm what version shall I opt for? (v5 or v6)
    v6 is going to be released soon and already have started being used by many.

  • Can you affirm what must-add components shall I include in the example?

Carbon is a collaborative system. We encourage teams to build components and
submit them for integration as either add-ons or core components.

Looking forward to be an active contributor to the community. Will be active in raising PR and fixing this.
Thanks,
sohamsshah

@joshblack joshblack changed the title [ENHANCEMENT]: Update the React-Router example to the latest version i.e. v5 or v6 Update the React-Router example to the latest version i.e. v5 or v6 Jun 14, 2021
@emyarod
Copy link
Member

emyarod commented Jun 15, 2021

hi @sohamsshah thank you for reporting this. you can update the existing React Router Carbon CodeSandbox example to v6. If you feel additional components can be included feel free to add those to your PR!

@sohamsshah
Copy link
Contributor Author

Awesome! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants