Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new tokens to theme package #8238

Closed
tw15egan opened this issue Mar 30, 2021 · 0 comments · Fixed by #8241
Closed

Add new tokens to theme package #8238

tw15egan opened this issue Mar 30, 2021 · 0 comments · Fixed by #8241
Assignees

Comments

@tw15egan
Copy link
Collaborator

tw15egan commented Mar 30, 2021

The first step to closing #8149 is to add the new tokens to the theme packages.

Until we create an alpha branch, we will add the new tokens to the theme package as references to the current tokens. That way, components can be updated to use the new tokens, but the old tokens will still be available.

For instance:

// current token references IDL color
export const interactive01 = blue60;

// new token, references old token until we create an alpha branch
export const backgroundBrand = interactive01;

Once we have an alpha branch, we can remove the old tokens, and have them reference the IDL colors directly

export const backgroundBrand = blue60;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants