Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button component CSS is not correct. #7809

Closed
2 tasks done
AmeanAsad opened this issue Feb 16, 2021 · 2 comments
Closed
2 tasks done

Button component CSS is not correct. #7809

AmeanAsad opened this issue Feb 16, 2021 · 2 comments

Comments

@AmeanAsad
Copy link

What package(s) are you using?

  • carbon-components
  • carbon-components-react

Detailed description

  • Browser: Chrome
  • Carbon Version :
    - carbon-components: 10.26.0
    - carbon-components-react: 7.26.0
  • Component: "Button"
  • Issue: The delete button color on the non-hover state is a shade of white.

Steps to reproduce the issue

  1. Import and use a Button component with kind="danger"

Additional information:

CSS:

Screen Shot 2021-02-12 at 3 44 02 PM

Rendered Button:
Screen Shot 2021-02-08 at 2 54 39 PM

  • Screenshots or code
  • Notes
@AmeanAsad
Copy link
Author

Looking further into the issue, it seems like the _buttons.scss file references a danger-01 and danger-02 theme tokens, yet these tokens are not defined.

Screen Shot 2021-02-16 at 11 42 49 AM

@emyarod
Copy link
Member

emyarod commented Feb 16, 2021

I believe these tokens were introduced in #7087, have you run yarn build recently?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants