Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal with long selectable data-table in modal body : selecting a row causes modal to content overflow #7682

Closed
1 task done
galilmori opened this issue Jan 28, 2021 · 1 comment · Fixed by #7698
Closed
1 task done

Comments

@galilmori
Copy link

galilmori commented Jan 28, 2021

What package(s) are you using?

  • @console/pal v1.337.5

Detailed description

Creating a modal with a table inside with selectable rows .
if you have a lot of selectable rows selecting the last row will cause the content to overflow outside of the modal.
causing a blank modal content

Steps to reproduce the issue

  • create a modal with long table content with selectable rows
  • scroll to the last element
  • select last element
  • content disappears

sandbnox replication of the issue : https://codesandbox.io/s/dark-bush-dedz7?file=/index.js

Additional information

image

Suggestions for fixing this

  • it appears that this can be fixed by adding position: relative to bx--modal-content currently its inheriting a static position in css
@wkeese
Copy link
Contributor

wkeese commented Sep 24, 2021

This fix causes regressions: dropdowns are clipped by the edge of the bx--modal-content node. Additionally, I think the real issue here is what I listed in #9403. Since #9403 is fixed this change should presumably be rolled back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants