Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[number input] audit bugs #7570

Closed
4 tasks
laurenmrice opened this issue Jan 14, 2021 · 1 comment · Fixed by #7919
Closed
4 tasks

[number input] audit bugs #7570

laurenmrice opened this issue Jan 14, 2021 · 1 comment · Fixed by #7919

Comments

@laurenmrice
Copy link
Member

  • We need to change the caret controls to a plus and a minus. Here is the final design spec 5417
    Number input (fixed) - White theme.png
    Number input (fixed) — Specs.png

  • There needs to be a 12px space between the control icons and the end of the field container.
    md-672px-8 column

  • In Safari, the input text is the wrong color for the disabled state in the dark themes. Should be disabled-02.

Screen Shot 2021-01-14 at 11 32 18 AM

  • The mobile variant will be the same as the enabled state for the regular number input.
    md-672px-8 column copy
@emyarod
Copy link
Member

emyarod commented Jan 28, 2021

#7687 will address the input controls overhaul, and after that is resolved we can deprecate the mobile input variant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants