Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overflow menu danger class gets support token #7467

Closed
DusanMilko opened this issue Dec 16, 2020 · 2 comments · Fixed by #7463
Closed

Overflow menu danger class gets support token #7467

DusanMilko opened this issue Dec 16, 2020 · 2 comments · Fixed by #7463

Comments

@DusanMilko
Copy link
Contributor

DusanMilko commented Dec 16, 2020

In the overflow menu the danger class gets the support-01 token. When doing theming the danger and support-01 can potentially be different colors. It makes more sense to me for overflow menu danger class to get danger token instead of support-01.

On my team the colors in custom themes can sometimes be different between the tokens and from our perspective the danger menu options should inherit the danger token color.

Screen Shot 2020-12-16 at 9 17 30 AM

@tw15egan
Copy link
Collaborator

tw15egan commented Dec 16, 2020

@laurenmrice in white/g10, support01 and danger01 are the same (red60)

However, in g90/g100 support01 is red40/red50 and danger01 is red60.

Currently, it is set to support-01. Can you confirm the color change is intentional when the overflow menu is used in a dark theme?

@laurenmrice
Copy link
Member

The overflow menu danger option should be updated to use the danger-01 token. It will be the same color across all themes. The support-01 token gets too light for the dark themes when paired with the usage of white text on top of it.

danger

@kodiakhq kodiakhq bot closed this as completed in #7463 Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants