Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data table sortable headers visual and programmatic labels do not match #7369

Closed
dakahn opened this issue Nov 30, 2020 · 0 comments · Fixed by #7383
Closed

Data table sortable headers visual and programmatic labels do not match #7369

dakahn opened this issue Nov 30, 2020 · 0 comments · Fixed by #7383

Comments

@dakahn
Copy link
Contributor

dakahn commented Nov 30, 2020

The programmatic and visual labels in the DataTable headers do not match. This is causing an AC violation
image

The programmatic (aria) label needs to match the visual label (for example "Product/Offering Name") or you'll have a Accessibility Checker violation that looks like this

a way of preserving the current label format and having assistive technologies describe usage information that's implied visually to a sighted user would be having some situation like this

<div style="display: none" id="usage-description-1">Click to sort</div>
<button aria-describedby="usage-description-1">Product/Offering Name</button>

That will read the label, element type, and it's intended effect nicely and avoid any AAT errors 👍

@dakahn dakahn changed the title Data table headers throw Accessibility Checker error Data table sortable headers visual and programmatic labels do not match Nov 30, 2020
@kodiakhq kodiakhq bot closed this as completed in #7383 Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants