Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip is escaping the screen when it is close right left bottom f the screen #7321

Closed
3 tasks done
galilmori opened this issue Nov 20, 2020 · 5 comments · Fixed by #9556
Closed
3 tasks done

Tooltip is escaping the screen when it is close right left bottom f the screen #7321

galilmori opened this issue Nov 20, 2020 · 5 comments · Fixed by #9556

Comments

@galilmori
Copy link

galilmori commented Nov 20, 2020

What package(s) are you using?

  • @console/pal v1.302.1
  • carbon-components v10.23.2
  • carbon-components-react v7.23.2

Detailed description

  • Tooltip is escaping from the screen when label is close to top bottom left or right borders

What did you expect to happen?

  • Tooltip stays within the screen borders

What happened instead?

  • Tooltip escapes the screen

What would you like to see changed?

  • Tooltip should stay in the screen while the sharkfin adapts and stays on the icon to which it is attached

What browser are you working in?

  • Google Chrome

What offering/product do you work on?

  • Ibm cloud Power-iaas. This issue is causing many accessibility and responsivity problems and it is very blocking for our product

Steps to reproduce the issue

  • create a label with Tooltip icon which is close to screen borders the tooltip will get out of at least one of the sides.

Reduced test case in CodeSandbox

Additional information

image

@tw15egan
Copy link
Collaborator

tw15egan commented Nov 23, 2020

Should be resolved via #7309 and using the new align prop align="start"

@galilmori
Copy link
Author

@tw15egan I am not sure if simply aligning tooltip manually would resolve overflow bugs of the tooltip.To me its more of a temporary solution. this is a fundamental problem where a tooltip has the possibility to escape the screen. In a responsive design depending if we have a big or small screen an object can be on the top bottom or right or left. carbon has 4 breakpoints added to that we can have even more if we want to support a large scale of devices. IMHO a tooltip should adapt its alignment if too close to escape the screen.

@dhyliu
Copy link

dhyliu commented Jan 5, 2021

@tw15egan I am signoff focal for accessibility compliance of offerings on IBM cloud. I need to urge the fixing action to this defect. May you advise the ETA to release the fix for this issue?

@TuxedoFish
Copy link
Contributor

Hey @tw15egan, is this something that I could pick up. We have been using v6 on a project and have a bug ticket related to this, but I saw it was an issue here too and was wondering if I could be assigned to this here?

The description of Tooltip should stay in the screen while the sharkfin adapts and stays on the icon to which it is attached sounds like something which would be a harmless improvement?

@tw15egan
Copy link
Collaborator

@TuxedoFish definitely feel free to push up a PR and have us take a look 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants