-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[code snippet] single line and multi-line bugs #7159
Comments
I'm also wondering if we should investigate adding in copy functionality by default (#6995) |
makes sense, if we're all on board with it then I can investigate that as well. I guess the biggest thing to look into would be browser and OS support |
It looks like https://stackoverflow.com/questions/39501289/in-reactjs-how-to-copy-text-to-clipboard |
for the light button hover styles, it looks like we are already using the and for the overflow indicators, what should the color tokens be? I have this ready to put in a separate PR but just need clarification on the colors |
There are a couple different bugs with the
single line
andmulti-line
code snippets.Single line:
The active state is not showing up when clicking on the copy button. It should be active-ui on click.
The horizontal scroll does not have a fade style. (This may be resolved with Andrews fix for horizontal tab scrolling.)
When the light prop is active, the dark themes have incorrect hover states for the copy button and show more button. They should be using
hover-light-ui
for hover. (this is also happening for inline code snippet)Multi-line:
hover-light-ui
for hover.The text was updated successfully, but these errors were encountered: