Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pagination] The footer should be singular if only one item/page #6624

Closed
amberfeinerman opened this issue Aug 6, 2020 · 1 comment · Fixed by #6675
Closed

[Pagination] The footer should be singular if only one item/page #6624

amberfeinerman opened this issue Aug 6, 2020 · 1 comment · Fixed by #6675

Comments

@amberfeinerman
Copy link

Detailed description

Describe in detail the issue you're having.

An issue was raised in my product team's repo regarding the pagination footer showing items if there was only one item and pages if there was only one page. I confirmed in lines 148 and 312 in Pagination.js that it was a Carbon issue.

Is this issue related to a specific component?

Pagination

What did you expect to happen? What happened instead? What would you like to
see changed?

Add conditional logic so that if max === 1 or totalPages === 1 the singular version of their noun shows.

Additional information

Screen Shot 2020-08-05 at 11 22 02 PM

@emyarod
Copy link
Member

emyarod commented Aug 14, 2020

as an FYI this can be resolved by passing in a custom pageRangeText function to handle the grammatical changes (which would be necessary for any i18n efforts anyway)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants