Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable Skeleton, have title and description skeleton as optional prop #6189

Closed
1 task done
SoSubtle opened this issue Jun 3, 2020 · 1 comment
Closed
1 task done

Comments

@SoSubtle
Copy link

SoSubtle commented Jun 3, 2020

Title line template: Add ability to remove title and description skeleton from DataTable skeleton

What package(s) are you using?

  • carbon-components-react

Detailed description

Hello. The latest DataTableSkeleton includes a skeleton for the datatable title and description. I was wondering if its possible to make the datatable title and description skeleton parts optional. Following the PAL guidelines our datatable component does not have an attached title or description so including the title and desc skeleton looks a bit off.

Please include a brief summary of what you would like to see changed here.
It would be nice to have the option to render the datatable skeleton without the title and description.

What we want : https://codesandbox.io/s/suspicious-raman-hhnyx

The latest version :
Screenshot 2020-05-29 at 17 49 21

@tw15egan
Copy link
Collaborator

tw15egan commented Jun 3, 2020

Closing as dup of #5993, will get a PR up shortly.

@tw15egan tw15egan closed this as completed Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants