Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React component API inconsistency between SelectableTile and RadioTile (misc properties) #5972

Closed
1 of 2 tasks
Tracked by #9356
hendriku opened this issue Apr 29, 2020 · 0 comments · Fixed by #10852
Closed
1 of 2 tasks
Tracked by #9356
Assignees
Labels
component: tile package: react carbon-components-react version: 11 Issues pertaining to Carbon v11
Milestone

Comments

@hendriku
Copy link

hendriku commented Apr 29, 2020

  • carbon-components
  • carbon-components-react

Summary

Currently the APIs of the components SelectableTile and RadioTile are behaving inconsistent in terms of where to forward the spread misc properties (...other/...rest) to. This results in e.g. the style property being passed to the label element in SelectableTile and to the (invisible) input element in RadioTile. While #5946 suggested an extraction of the style property @asudoh and me had the opinion that it would be a better to resolve the inconsistency of the components as a whole. This can be done via forwarding the misc properties to the equivalent elements, but this would cause a breaking change.

This issues purpose is to discuss the solution for resolving the inconsistency.

Relevant information

Currently a functional workaround is to use DOM refs to pass HTML attributes manually to the underlaying elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tile package: react carbon-components-react version: 11 Issues pertaining to Carbon v11
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants