Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pictograms] update dash naming structure #5905

Closed
laurenmrice opened this issue Apr 21, 2020 · 2 comments
Closed

[pictograms] update dash naming structure #5905

laurenmrice opened this issue Apr 21, 2020 · 2 comments
Labels
package: pictograms @carbon/pictograms role: dev 🤖

Comments

@laurenmrice
Copy link
Member

laurenmrice commented Apr 21, 2020 •
edited
Loading

We need to change the pictogram naming structure to follow the dash convention we use for icons, to help keep things consistent

Naming convention:
(-) for spaces
(--) for variants

-I made this update to the newest pictogram pr #5674 , so we just need to update the other pictograms in our package.
@emyarod
Copy link
Member

emyarod commented Apr 21, 2020

this means we will also need to deprecate any renamed pictograms right?

@emyarod emyarod self-assigned this Apr 21, 2020
@joshblack
Copy link
Contributor

Going to close this out due to inactivity, feel free to comment and I can re-open!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package: pictograms @carbon/pictograms role: dev 🤖
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joshblack @emyarod @laurenmrice