Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icons] rendering problems with sketch #5758

Closed
laurenmrice opened this issue Mar 31, 2020 · 3 comments · Fixed by #6912
Closed

[icons] rendering problems with sketch #5758

laurenmrice opened this issue Mar 31, 2020 · 3 comments · Fixed by #6912
Assignees

Comments

@laurenmrice
Copy link
Member

laurenmrice commented Mar 31, 2020

The actual icon asset is rendering a little off when be put into sketch. This may be something Conrad will need to look into.


16/help--filled Has an uneven circle in the question mark
Screen Shot 2020-03-30 at 11 30 39 AM

16/information--filled and 16/information Have uneven circle in the i.
Screen Shot 2020-03-30 at 11 31 33 AM

16/notificationand 16/notification--off gets weird rendering around corners
Screen Shot 2020-03-30 at 10 24 14 AM

16px only: play play--outline gets weird rendering around corners
Screen Shot 2020-03-30 at 10 27 56 AM

20/redo gets weird rendering on arrow line
Screen Shot 2020-03-30 at 10 36 33 AM

16/save is getting weird rendering on corners.

Screen Shot 2020-03-30 at 11 48 52 AM

16/star and 20/star are getting weird rendering on corners.
Screen Shot 2020-03-30 at 11 52 53 AM

16/view and 16/view--off has cutoff ends and weird rendering.
Screen Shot 2020-03-30 at 12 00 04 PM

16/warning--alt--filled and 16/warning--altare getting weird rendering on corners.
Screen Shot 2020-03-30 at 12 06 31 PM

16/warning--filled has an uneven circle of the exclamation point.

Screen Shot 2020-03-30 at 12 05 54 PM

16/asleep gets weird rendering around corners
Screen Shot 2020-03-30 at 11 23 24 AM

@joshblack
Copy link
Contributor

cc @conradennis would you have time to sync up on some of these rendering issues that we're noticing?

@conradennis
Copy link
Contributor

@joshblack for sure, feel free to put some time on my calendar

@laurenmrice
Copy link
Member Author

closing 🎉 Pr fix: #7126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants