Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Button]: Disabled ghost icon-only Button missing associated label #5741

Closed
zJag opened this issue Mar 27, 2020 · 1 comment · Fixed by #5761
Closed

[Button]: Disabled ghost icon-only Button missing associated label #5741

zJag opened this issue Mar 27, 2020 · 1 comment · Fixed by #5761

Comments

@zJag
Copy link

zJag commented Mar 27, 2020

Environment

Browser

Chrome (others are probably effected)

Automated testing tool and ruleset

DAP Chrome Extension

Detailed description

What version of the Carbon Design System are you using?

v10.10.0

What did you expect to happen?

Using an icon-only ghost Button from carbon-components-react should not cause violations with DAP.

What happened instead?

When disabled, the button causes a violation with DAP stating the associated label is missing.

What WCAG 2.1 checkpoint does the issue violate?

Steps to reproduce the issue

  1. Render an icon-only ghost button with proper props.
  2. Disable the button.
  3. Run the DAP extension

CodeSandbox

Additional information

This could be fixed by not hiding the assistive text when the button is disabled (in carbon-components). This could also be fixed in carbon-components-react by ensuring the icon-only button receives an accessible name. For the latter, I was able to create a fix on my forked branch, and would be able to submit a PR if that's the proper solution.

@tw15egan
Copy link
Collaborator

tw15egan commented Mar 31, 2020

Since the rest of the buttons still have the assistive text when disabled, we should just remove the styles that are specific to the ghost button. PR Incoming 🚀

https://github.com/carbon-design-system/carbon/pull/5313/files#diff-b73d9732aa1bfa4b943f188fdd4bfeccR228-R232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants