You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This could be fixed by not hiding the assistive text when the button is disabled (in carbon-components). This could also be fixed in carbon-components-react by ensuring the icon-only button receives an accessible name. For the latter, I was able to create a fix on my forked branch, and would be able to submit a PR if that's the proper solution.
The text was updated successfully, but these errors were encountered:
Since the rest of the buttons still have the assistive text when disabled, we should just remove the styles that are specific to the ghost button. PR Incoming 🚀
Environment
Chrome (others are probably effected)
DAP Chrome Extension
Detailed description
v10.10.0
Using an icon-only ghost Button from
carbon-components-react
should not cause violations with DAP.When disabled, the button causes a violation with DAP stating the associated label is missing.
Steps to reproduce the issue
CodeSandbox
Additional information
aria-hidden
attribute.This could be fixed by not hiding the assistive text when the button is disabled (in
carbon-components
). This could also be fixed incarbon-components-react
by ensuring the icon-only button receives an accessible name. For the latter, I was able to create a fix on my forked branch, and would be able to submit a PR if that's the proper solution.The text was updated successfully, but these errors were encountered: