Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JAWS issues with carbon components (for IBM Blockchain usage) #5687

Closed
matthewgallo opened this issue Mar 24, 2020 · 6 comments
Closed

JAWS issues with carbon components (for IBM Blockchain usage) #5687

matthewgallo opened this issue Mar 24, 2020 · 6 comments

Comments

@matthewgallo
Copy link
Member

matthewgallo commented Mar 24, 2020

Components that we've seen this behavior:
<Dropdown /> ----> https://github.ibm.com/IBM-Blockchain/OpTools/issues/3696, https://github.ibm.com/IBM-Blockchain/OpTools/issues/3712
<FileUploader /> ----> https://github.ibm.com/IBM-Blockchain/OpTools/issues/3702
<Button /> ----> https://github.ibm.com/IBM-Blockchain/OpTools/issues/3702
<Slider /> ----> https://github.ibm.com/IBM-Blockchain/OpTools/issues/3709, https://github.ibm.com/IBM-Blockchain/OpTools/issues/3711

Environment

Operating system
Windows (via Microsoft remote desktop from Mac)
Browser
Edge
Assistive technology used to verify
JAWS

Detailed description

We have received an a11y issue after our application went through AVT testing. The main issue is that the form label that JAWS should read is the visible label text of the dropdown, however, it is reading/setting the first item in the dropdown as the form label.

What version of the Carbon Design System are you using?

"carbon-components": "^10.10.2",
"carbon-components-react": "^7.10.2",

What did you expect to happen?
Expected the visible dropdown label to match the form label that JAWS reads to the user.
What happened instead?
The first item in the dropdown was selected as the form label.
What WCAG 2.1 checkpoint does the issue violate?

Steps to reproduce the issue

  1. Keep JAWS running
  2. Login to the https://test.cloud.ibm.com/
  3. Open https://test.cloud.ibm.com/resources
  4. Open an existing Blockchain Platform 2.0 service
  5. Click on Launch the IBM Blockchain Platform button
  6. Switch the Settings tab
  7. Press Insert+F5 to open Forms dialog

Please create a reduced test case in CodeSandbox

Additional information

See additional info from the AVT issue/s we received:
https://github.ibm.com/IBM-Blockchain/OpTools/issues/3696
https://github.ibm.com/IBM-Blockchain/OpTools/issues/3712
https://github.ibm.com/IBM-Blockchain/OpTools/issues/3702 (similar issue but for <Button /> and <FileUploader /> component)
https://github.ibm.com/IBM-Blockchain/OpTools/issues/3709 (similar issue but for <Slider /> component)
https://github.ibm.com/IBM-Blockchain/OpTools/issues/3711

@matthewgallo matthewgallo changed the title Dropdown a11y JAWS issue, form label does not match visible label text JAWS issues with carbon components (for IBM Blockchain usage) Mar 24, 2020
@joshblack joshblack mentioned this issue Mar 27, 2020
79 tasks
@joshblack
Copy link
Contributor

cc @dakahn would you have a chance today/tomorrow to help verify these issues in JAWS? Would love to pair up on it too if you want just to learn how to do this with JAWS 👀

@dakahn
Copy link
Contributor

dakahn commented May 13, 2020

We'll test this against the newly upgraded Downshift tomorrow and report back. Thanks for reporting 👍

@matthewgallo
Copy link
Member Author

Thanks @dakahn and @joshblack!

@dakahn
Copy link
Contributor

dakahn commented May 15, 2020

Did a check on our master branch with the Downshift update on Windows 10 with JAWS 2020 on Firefox latest. The form element's designated label "This is a dropdown title" was read correctly followed by the Dropdown's label "Dropdown Menu Options".

I'm going to close this issue as resolved since I'm also unable to reproduce the errors mentioned for Button and FileUploader. We can reopen if the AVT errors persist once you've gotten the aforementioned updates.

@dakahn dakahn closed this as completed May 15, 2020
@matthewgallo
Copy link
Member Author

Hey @dakahn, just wanted to follow up. Glad to hear that the new version of downshift doesn't have this violation anymore for the dropdown. Could you possibly check the other components that had this same violation as well? I believe they were the FileUploader, Button, and Slider

@dakahn
Copy link
Contributor

dakahn commented May 26, 2020

@matthewgallo we should open distinct tickets for those issues. I can do this for you sometime today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants